Merge lp:~michaelh1/linaro-image-tools/fractional-partitions into lp:linaro-image-tools/11.11

[Michael Hope]

Support floating point image sizes such as --image-size 1.9G

[Данило Шеган (danilo)]

Michael, thanks for working on this. This generally looks good, but please add a test for float values being passed in. Just add another test along the lines of test_convert_size_in_kbytes_to_bytes to
linaro_image_tools/media_create/tests/test_media_create.py that tests the new behavior.

Considering we are adding support for floats, one will also be able to say something like 1.0005K. What would you expect the proper behavior to be in that case? I'd expect 1001 bytes to be returned, so I'd also modify the return to round upwards, i.e.
  return int(real_size + 0.5)

(and add a test for this particular behavior as well).

It would also be good to file a bug for this feature request, so we can easily track what's going into the next release, so please do that as well.

review: Needs Fixing

[Michael Hope (michaelh1)]

Continued in https://code.launchpad.net/~michaelh1/linaro-image-tools/float-image-size/+merge/105270

review: Needs Fixing

Unmerged revisions

515. By Michael Hope on 2012-05-04

Support fractional partition sizes.

=== modified file 'linaro_image_tools/media_create/partitions.py'
--- linaro_image_tools/media_create/partitions.py	2012-04-18 14:18:34 +0000
+++ linaro_image_tools/media_create/partitions.py	2012-05-04 04:36:18 +0000
@@ -484,7 +484,7 @@
     # no unit? (ends with a digit)
     if unit in '0123456789':
         return int(size)
-    real_size = int(size[:-1])
+    real_size = float(size[:-1])
     if unit == 'K':
         real_size = real_size * 1024
     elif unit == 'M':
@@ -495,7 +495,7 @@
         raise ValueError("Unknown size format: %s.  Use K[bytes], M[bytes] "
                          "or G[bytes]" % size)
 
-    return real_size
+    return int(real_size)
 
 
 def run_sfdisk_commands(commands, heads, sectors, cylinders, device,