Merge lp:~michaelh1/gcc-linaro/unaligned-copies-2 into lp:gcc-linaro/4.6

Proposed by Michael Hope
Status: Merged
Approved by: Richard Sandiford
Approved revision: not available
Merge reported by: Michael Hope
Merged at revision: not available
Proposed branch: lp:~michaelh1/gcc-linaro/unaligned-copies-2
Merge into: lp:gcc-linaro/4.6
To merge this branch: bzr merge lp:~michaelh1/gcc-linaro/unaligned-copies-2
Reviewer Review Type Date Requested Status
Richard Sandiford Approve
Review via email: mp+80639@code.launchpad.net

This proposal supersedes a proposal from 2011-10-19.

Description of the change

Backport from mainline r180131.

Adds unaligned block move support for ARMv7. Backported the __ARM_FEATURE_UNALIGNED macro to enable the unaligned tests.

To post a comment you must log in.
Revision history for this message
Michael Hope (michaelh1) wrote : Posted in a previous version of this proposal

cbuild has taken a snapshot of this branch at r106829 and queued it for build.

The diff against the ancestor r106828 is available at:
 http://builds.linaro.org/toolchain/snapshots/gcc-linaro-4.6+bzr106829~michaelh1~unaligned-copies-2.diff

and will be built on the following builders:
 a9-builder armv5-builder i686 x86_64

You can track the build queue at:
 http://ex.seabright.co.nz/helpers/scheduler

cbuild-snapshot: gcc-linaro-4.6+bzr106829~michaelh1~unaligned-copies-2
cbuild-ancestor: lp:gcc-linaro+bzr106828
cbuild-state: check

Revision history for this message
Michael Hope (michaelh1) wrote : Posted in a previous version of this proposal
Revision history for this message
Michael Hope (michaelh1) wrote : Posted in a previous version of this proposal
Revision history for this message
Michael Hope (michaelh1) wrote : Posted in a previous version of this proposal

cbuild successfully built this on armv7l-natty-cbuild201-tcpanda05-armv5r2.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106829~michaelh1~unaligned-copies-2/logs/armv7l-natty-cbuild201-tcpanda05-armv5r2

+UNSUPPORTED: gcc.target/arm/unaligned-memcpy-1.c
+UNSUPPORTED: gcc.target/arm/unaligned-memcpy-2.c
+UNSUPPORTED: gcc.target/arm/unaligned-memcpy-3.c
+UNSUPPORTED: gcc.target/arm/unaligned-memcpy-4.c

The full diff is at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106829~michaelh1~unaligned-copies-2/logs/armv7l-natty-cbuild201-tcpanda05-armv5r2/testsuite-diff.txt

The full testsuite results are at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106829~michaelh1~unaligned-copies-2/logs/armv7l-natty-cbuild201-tcpanda05-armv5r2/gcc-testsuite.txt

cbuild-checked: armv7l-natty-cbuild201-tcpanda05-armv5r2

Revision history for this message
Michael Hope (michaelh1) wrote : Posted in a previous version of this proposal

cbuild successfully built this on armv7l-natty-cbuild201-tcpanda04-cortexa9r1.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106829~michaelh1~unaligned-copies-2/logs/armv7l-natty-cbuild201-tcpanda04-cortexa9r1

+UNSUPPORTED: gcc.target/arm/unaligned-memcpy-1.c
+UNSUPPORTED: gcc.target/arm/unaligned-memcpy-2.c
+UNSUPPORTED: gcc.target/arm/unaligned-memcpy-3.c
+UNSUPPORTED: gcc.target/arm/unaligned-memcpy-4.c

The full diff is at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106829~michaelh1~unaligned-copies-2/logs/armv7l-natty-cbuild201-tcpanda04-cortexa9r1/testsuite-diff.txt

The full testsuite results are at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106829~michaelh1~unaligned-copies-2/logs/armv7l-natty-cbuild201-tcpanda04-cortexa9r1/gcc-testsuite.txt

cbuild-checked: armv7l-natty-cbuild201-tcpanda04-cortexa9r1

Revision history for this message
Michael Hope (michaelh1) wrote : Posted in a previous version of this proposal

The test cases check a #define to see if unaligned access is supported. Will backport something appropriate.

Revision history for this message
Michael Hope (michaelh1) wrote :

cbuild has taken a snapshot of this branch at r106830 and queued it for build.

The diff against the ancestor r106828 is available at:
 http://builds.linaro.org/toolchain/snapshots/gcc-linaro-4.6+bzr106830~michaelh1~unaligned-copies-2.diff

and will be built on the following builders:
 a9-builder armv5-builder i686 x86_64

You can track the build queue at:
 http://ex.seabright.co.nz/helpers/scheduler

cbuild-snapshot: gcc-linaro-4.6+bzr106830~michaelh1~unaligned-copies-2
cbuild-ancestor: lp:gcc-linaro+bzr106828
cbuild-state: check

Revision history for this message
Michael Hope (michaelh1) wrote :
Revision history for this message
Michael Hope (michaelh1) wrote :

cbuild successfully built this on armv7l-natty-cbuild205-tcpanda05-armv5r2.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106830~michaelh1~unaligned-copies-2/logs/armv7l-natty-cbuild205-tcpanda05-armv5r2

+UNSUPPORTED: gcc.target/arm/unaligned-memcpy-1.c
+UNSUPPORTED: gcc.target/arm/unaligned-memcpy-2.c
+UNSUPPORTED: gcc.target/arm/unaligned-memcpy-3.c
+UNSUPPORTED: gcc.target/arm/unaligned-memcpy-4.c

The full diff is at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106830~michaelh1~unaligned-copies-2/logs/armv7l-natty-cbuild205-tcpanda05-armv5r2/testsuite-diff.txt

The full testsuite results are at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106830~michaelh1~unaligned-copies-2/logs/armv7l-natty-cbuild205-tcpanda05-armv5r2/gcc-testsuite.txt

cbuild-checked: armv7l-natty-cbuild205-tcpanda05-armv5r2

Revision history for this message
Michael Hope (michaelh1) wrote :

cbuild successfully built this on armv7l-natty-cbuild205-tcpanda04-cortexa9r1.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106830~michaelh1~unaligned-copies-2/logs/armv7l-natty-cbuild205-tcpanda04-cortexa9r1

+PASS: gcc.target/arm/unaligned-memcpy-1.c (test for excess errors)
+PASS: gcc.target/arm/unaligned-memcpy-1.c scan-assembler-times @ unaligned 8
+PASS: gcc.target/arm/unaligned-memcpy-1.c scan-assembler-times ldrb 1
+PASS: gcc.target/arm/unaligned-memcpy-1.c scan-assembler-times ldrh 1
+PASS: gcc.target/arm/unaligned-memcpy-1.c scan-assembler-times strb 1
+PASS: gcc.target/arm/unaligned-memcpy-1.c scan-assembler-times strh 1
+PASS: gcc.target/arm/unaligned-memcpy-2.c (test for excess errors)
+PASS: gcc.target/arm/unaligned-memcpy-2.c scan-assembler-times ldrb 1
+PASS: gcc.target/arm/unaligned-memcpy-2.c scan-assembler-times ldrh 1
+PASS: gcc.target/arm/unaligned-memcpy-2.c scan-assembler-times stmia 1
+PASS: gcc.target/arm/unaligned-memcpy-2.c scan-assembler-times strb 1
+PASS: gcc.target/arm/unaligned-memcpy-2.c scan-assembler-times strh 1
+PASS: gcc.target/arm/unaligned-memcpy-3.c (test for excess errors)
+PASS: gcc.target/arm/unaligned-memcpy-3.c scan-assembler-times ldmia 1
+PASS: gcc.target/arm/unaligned-memcpy-3.c scan-assembler-times ldrb 1
+PASS: gcc.target/arm/unaligned-memcpy-3.c scan-assembler-times ldrh 1
+PASS: gcc.target/arm/unaligned-memcpy-3.c scan-assembler-times strb 1
+PASS: gcc.target/arm/unaligned-memcpy-3.c scan-assembler-times strh 1
+PASS: gcc.target/arm/unaligned-memcpy-4.c (test for excess errors)
+PASS: gcc.target/arm/unaligned-memcpy-4.c scan-assembler-times ldmia 1
+PASS: gcc.target/arm/unaligned-memcpy-4.c scan-assembler-times stmia 1

The full diff is at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106830~michaelh1~unaligned-copies-2/logs/armv7l-natty-cbuild205-tcpanda04-cortexa9r1/testsuite-diff.txt

The full testsuite results are at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106830~michaelh1~unaligned-copies-2/logs/armv7l-natty-cbuild205-tcpanda04-cortexa9r1/gcc-testsuite.txt

cbuild-checked: armv7l-natty-cbuild205-tcpanda04-cortexa9r1

Revision history for this message
Michael Hope (michaelh1) wrote :
Revision history for this message
Michael Hope (michaelh1) wrote :

Testing turned out fine. Past benchmarking shows no significant (> 1 %) regressions. Please review.

Revision history for this message
Richard Sandiford (rsandifo) wrote :

OK

review: Approve

Subscribers

People subscribed via source and target branches