Code review comment for lp:~michael.rawson/unity/fix-show-desktop

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

4 + for (auto icon : *(pimpl->model_)) {
55 + if (icon->ShowInSwitcher(current)) {
56 + //otherwise we get two desktop icons in the switcher.
57 + if (icon->GetIconType()!=AbstractLauncherIcon::IconType::TYPE_DESKTOP) {
58 + results.push_back(icon);
59 + }
60 + }
61 + }

I'm sorry, maybe you misunderstood me: the brackets should be o new line (plus the != should be spaced and pay attention not to put trailing spaces). So the above code should have been:

for (auto icon : *(pimpl->model_))
{
  if (icon->ShowInSwitcher(current))
  {
    //otherwise we get two desktop icons in the switcher.
    if (icon->GetIconType() != AbstractLauncherIcon::IconType::TYPE_DESKTOP)
    {
      results.push_back(icon);
    }
  }
}

;)

« Back to merge proposal