Merge lp:~michael.nelson/ubuntu-webcatalog/update-requirements into lp:ubuntu-webcatalog

Proposed by Michael Nelson
Status: Merged
Approved by: Michael Nelson
Approved revision: 58
Merged at revision: 57
Proposed branch: lp:~michael.nelson/ubuntu-webcatalog/update-requirements
Merge into: lp:ubuntu-webcatalog
Diff against target: 72 lines (+23/-17)
3 files modified
fabtasks/bootstrap.py (+1/-1)
setup.py (+17/-1)
test_requirements.txt (+5/-15)
To merge this branch: bzr merge lp:~michael.nelson/ubuntu-webcatalog/update-requirements
Reviewer Review Type Date Requested Status
Łukasz Czyżykowski (community) Approve
Review via email: mp+82522@code.launchpad.net

Commit message

Move package requirements into setup.py and rename requirements.txt -> test_requirements.txt

Description of the change

Overview
========

This branch just splits out the requirements so that those required to install the package are included in the setup.py, while the remaining test requirements stay in the renamed requirements file.

To test: `fab bootstrap && fab test`

Note: I had one issue, documented in the test_requirements.txt file.
Note: I'm just doing this so I can `python setup.py install` the app.

To post a comment you must log in.
Revision history for this message
Łukasz Czyżykowski (lukasz-czyzykowski) wrote :

All looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'fabtasks/bootstrap.py'
2--- fabtasks/bootstrap.py 2011-09-12 13:37:24 +0000
3+++ fabtasks/bootstrap.py 2011-11-17 12:03:25 +0000
4@@ -28,7 +28,7 @@
5
6
7 def install_requirements():
8- local("virtualenv/bin/pip install -r requirements.txt", capture=False)
9+ local("virtualenv/bin/pip install -r test_requirements.txt", capture=False)
10 local("virtualenv/bin/python setup.py develop", capture=False)
11 symlink_python_apt()
12 symlink_gtk2()
13
14=== modified file 'setup.py'
15--- setup.py 2011-06-20 21:47:45 +0000
16+++ setup.py 2011-11-17 12:03:25 +0000
17@@ -33,10 +33,26 @@
18 packages = find_packages('src'),
19 package_dir = {'': 'src'},
20 install_requires = [
21+ 'django',
22 'setuptools',
23- 'django',
24 'south',
25+ 'configglue==0.10',
26+ 'django-configglue==0.4',
27+ 'django-openid-auth==0.2',
28+ 'django-piston',
29+ 'django-preflight',
30+ 'python-debian',
31+ 'python-openid',
32+ 'oauth',
33+ 'httplib2',
34+ 'django-pgtools==0.1',
35+ 'PIL',
36+ 'lazr.restfulclient',
37 ],
38 package_data = find_packages_data('src'),
39+ dependency_links = [
40+ 'http://launchpad.net/django-pgtools/trunk/0.1/+download/django-pgtools-0.1.tar.gz#egg=django-pgtools-0.1',
41+ ],
42+
43 )
44
45
46=== renamed file 'requirements.txt' => 'test_requirements.txt'
47--- requirements.txt 2011-07-19 15:44:09 +0000
48+++ test_requirements.txt 2011-11-17 12:03:25 +0000
49@@ -1,18 +1,8 @@
50-configglue==0.10
51+# django should not be required here, but without it `python setup.py develop`
52+# complains with:
53+# Installed /.../virtualenv/lib/python2.6/site-packages/django_preflight-0.1-py2.6.egg
54+# error: Could not find required distribution django
55+django
56 coverage
57-django
58-django-configglue==0.4
59-django-openid-auth==0.2
60-django-piston
61--e bzr+http://bazaar.launchpad.net/~canonical-isd-hackers/django-pgtools/trunk
62-django-preflight
63 mock
64-PIL
65 piston-mini-client
66-python-debian
67-python-openid
68-setuptools
69-south
70-oauth
71-httplib2
72-lazr.restfulclient

Subscribers

People subscribed via source and target branches