Ubuntu Apps Directory

Merge lp:~michael.nelson/ubuntu-webcatalog/g-plus-cropped into lp:ubuntu-webcatalog

  1. g-plus-cropped
  2. Merge into trunk
Proposed by Michael Nelson
Status: Merged
Approved by: Anthony Lenton
Approved revision: 126
Merged at revision: 126
Proposed branch: lp:~michael.nelson/ubuntu-webcatalog/g-plus-cropped
Merge into: lp:ubuntu-webcatalog
Diff against target: 12 lines (+1/-1)
1 file modified
src/webcatalog/static/css/webcatalog.css (+1/-1)
To merge this branch: bzr merge lp:~michael.nelson/ubuntu-webcatalog/g-plus-cropped
Reviewer Review Type Date Requested Status
Anthony Lenton (community) Approve
Review via email: mp+107782@code.launchpad.net

Commit message

top-align the share widgets.

Description of the change

I'm no designer, but after seeing dpitkins branch at:

https://code.launchpad.net/~dpitkin/ubuntu-webcatalog/fix-facebook-css/+merge/107383

top-aligning the widgets looks cleaner to my untrained eye :) This is just a slight modification to dpitkin's tweak which works in both FF and chromium.

http://people.canonical.com/~michaeln/tmp/fb-vertical-align-top-ff.png

http://people.canonical.com/~michaeln/tmp/fb-vertical-align-top-chromium.png

(Originally I'd seen the G+ widget cropped this morning in FF, but can't reproduce now, perhaps it was related to the G+ widget.)

To post a comment you must log in.
Revision history for this message
Anthony Lenton (elachuni) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/webcatalog/static/css/webcatalog.css'
2--- src/webcatalog/static/css/webcatalog.css 2012-05-04 10:27:11 +0000
3+++ src/webcatalog/static/css/webcatalog.css 2012-05-29 13:33:21 +0000
4@@ -59,7 +59,7 @@
5 padding: 16px;
6 }
7 .share .fb-like {
8- height: 24px;
9+ vertical-align: top;
10 }
11 .description {
12 padding: 42px 16px;

Subscribers

People subscribed via source and target branches