Merge lp:~michael.nelson/ubuntu-webcatalog/1169225-long-names into lp:ubuntu-webcatalog

[Michael Nelson]

Don't save displayname.

Don't save first/last name.

We're getting hundreds of oopses per day (see linked bug) due to authenticated requests to the oneconf api when we try to save the display names of the authenticating user.

We don't use the information anywhere in the codebase. We could update the db columns (as we did with sca), but as its django.contrib.auth, not an app of our own, I'd personally prefer to do that only if we were using the data.

Another option I'd be ok with is simply truncating the first and last names to the max length before saving. Happy to update to that if you prefer.

`fab test`

[Martin Albisetti (beuno)]

review: Approve

=== modified file 'src/webcatalog/auth.py'
--- src/webcatalog/auth.py	2012-06-30 00:09:12 +0000
+++ src/webcatalog/auth.py	2013-04-16 12:07:29 +0000
@@ -121,12 +121,6 @@
                                                 password=None)
                 user.useropenid_set.create(claimed_id=claimed_id)
 
-            displayname = pieces['displayname']
-            if displayname != user.get_full_name():
-                user.first_name, sep, user.last_name = displayname.rpartition(
-                    ' ')
-                user.save()
-
             consumer, created = Consumer.objects.get_or_create(
                 user=user, key=consumer_key, secret=pieces['consumer_secret'])
             token, created = Token.objects.get_or_create(