Merge lp:~michael.nelson/ubuntu-webcatalog/1039073-click-url-should-open-in-own-window into lp:ubuntu-webcatalog

[Michael Nelson]

Tiny change so that clicks on an exhibit open the url in a new tab.

At first I was unsure if we should do this for all exhibits, or just those with click_url's (ie. external), but it seemed inconsistent to do it only for some exhibits. That said, if it's related to the external/internal link, maybe it would be better only do on external? Let me know.

I'm personally -1 to opening in a new tab/window - I don't really see the benefit in our use-case.

[Łukasz Czyżykowski (lukasz-czyzykowski)]

review: Approve

=== modified file 'src/webcatalog/templates/webcatalog/exhibits_widget.html'
--- src/webcatalog/templates/webcatalog/exhibits_widget.html	2012-03-08 18:00:09 +0000
+++ src/webcatalog/templates/webcatalog/exhibits_widget.html	2012-08-21 13:49:19 +0000
@@ -10,7 +10,7 @@
         {% endcomment %}
         {% for exhibit in exhibits %}
         <li class="slide{% if forloop.counter > 1%} disabled{% endif %}">
-            <a href="{{ exhibit.destination_url }}">
+            <a {% if exhibit.click_url %}target="_blank"{% endif %} href="{{ exhibit.destination_url }}">
         {{ exhibit.html }}
             </a>
         </li>