Merge lp:~michael.nelson/launchpad/db_soyuz_js_tests_broken into lp:launchpad/db-devel

[Michael Nelson]

[Michael Nelson (michael.nelson)]

= Summary =

This branch fixes two things. First, it updates the soyuz js unit-tests
so that they work. Second, it updates the DynamicDomUpdater plugin to
work with YUI3.

== Proposed fix ==

Update tests to use 'test' instead of 'yuitest'.

Update the plugin to use the new 'host' attribute rather than the
previous 'owner' attribute, for the node hosting the plugin.

== Pre-implementation notes ==

== Implementation details ==

== Tests ==

firefox
lib/canonical/launchpad/javascript/soyuz/tests/lp_dynamic_dom_updater.html

firefox
lib/canonical/launchpad/javascript/soyuz/tests/archivesubscribers_index.html

== Demo and Q/A ==

= Launchpad lint =

Lint seems to have linted more than just the files I've changed, but all
the files I've changed (under javascript/soyuz) are lint-free.

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/canonical/launchpad/javascript/soyuz/tests/lp_dynamic_dom_updater.js
  lib/canonical/launchpad/javascript/soyuz/tests/archivesubscribers_index.js
  lib/canonical/launchpad/javascript/soyuz/lp_dynamic_dom_updater.js

== JSLint notices ==
jslint: Lint found in
'/home/michael/canonical/lp-branches/db_soyuz_js_tests_broken/lib/canonical/launchpad/javascript/bugs/bug_tags_entry.js':
Line 68 character 42: Use '!==' to compare with ''.
            function(elem) { return elem != ''; });

Line 106 character 40: Use '===' to compare with ''.
            if (Y.Lang.trim(tags_html) == '') {

Line 132 character 23: Line breaking error ')'.
    autocomplete.hide()

Line 132 character 24: Missing semicolon.
    autocomplete.hide()

Line 134 character 53: Use '===' to compare with ''.
    if (Y.Lang.trim(tag_list_span.get('innerHTML')) == '') {

Line 164 character 25: ['me'] is better written in dot notation.
    if (LP.client.links['me'] === undefined) { return; }

Line 217 character 43: Line breaking error ')'.
    edit_tags_trigger.addClass('js-action')

Line 217 character 44: Missing semicolon.
    edit_tags_trigger.addClass('js-action')

Line 228 character 22: Use '!==' to compare with 'null'.
        if (e.newVal != null) {

jslint: No problem found in
'/home/michael/canonical/lp-branches/db_soyuz_js_tests_broken/lib/canonical/launchpad/javascript/bugs/bugtask-index.js'.

jslint: No problem found in
'/home/michael/canonical/lp-branches/db_soyuz_js_tests_broken/lib/canonical/launchpad/javascript/bugs/filebug-dupefinder.js'.

jslint: Lint found in
'/home/michael/canonical/lp-branches/db_soyuz_js_tests_broken/lib/canonical/launchpad/javascript/bugs/offical_bug_tags.js':
Line 81 character 19: Use '===' to compare with 'null'.
        if (count == null) {

Line 147 character 20: Use '===' to compare with '0'.
    if (item.count == 0) {

Line 304 character 23: Use '===' to compare with 'null'.
            if (count == null) {

Line 403 character 57: Use '===' to compare with ''.
        Y.one('#new-tag-add').set('disabled', new_value == '');

jslint: No problem found in
'/home/michael/canonical/lp-branches/db_soyuz_js_tests_broken/lib/canonical/launchpad/javascript/bugs/subscriber.js'.

jslint: No problem foun...

[Māris Fogels (mars)]

Hi Michael,

Thanks for running lint. Seems it has slipped out from under our regular review process :)

Your changes look good. r=mars

I though of one future enhancement for this code, now that we have some more YUI experience: it could be lightened up to only use 'plugin-base', instead of pulling in the whole 'plugin' module and its dependencies. But that is for another day.

Maris

review: Approve

=== modified file 'lib/canonical/launchpad/javascript/soyuz/lp_dynamic_dom_updater.js'
--- lib/canonical/launchpad/javascript/soyuz/lp_dynamic_dom_updater.js	2009-11-24 09:30:01 +0000
+++ lib/canonical/launchpad/javascript/soyuz/lp_dynamic_dom_updater.js	2009-11-24 17:00:32 +0000
@@ -41,17 +41,7 @@
 
     DomUpdater.ATTRS = {
         /**
-         * The dom node to which this plugin instance is attached.
-         *
-         * @attribute owner
-         * @type Node
-         */
-        owner: {
-            value: null
-        },
-
-        /**
-         * The function that updates the owner's dom subtree.
+         * The function that updates the host's dom subtree.
          *
          * @attribute domUpdateFunction
          * @type Function
@@ -62,7 +52,7 @@
         }
     };
 
-    Y.extend(DomUpdater, Y.Plugin, {
+    Y.extend(DomUpdater, Y.Plugin.Base, {
 
         /**
          * The update method simply passes through to the user provided
@@ -73,11 +63,11 @@
          *        passed to the users domUpdateFunction.
          */
         update: function(update_data) {
-            Y.log("Updating Dom subtree for " + this.get("owner"),
+            Y.log("Updating Dom subtree for " + this.get("host"),
                   "info", "DomUpdater");
             var domUpdateFunction = this.get("domUpdateFunction");
             if (domUpdateFunction !== null){
-                domUpdateFunction(this.get("owner"), update_data);
+                domUpdateFunction(this.get("host"), update_data);
             }
         }
 
@@ -219,7 +209,7 @@
          * @protected
          */
         initializer: function(){
-            Y.log("Initializing updater for " + this.get("owner") +
+            Y.log("Initializing updater for " + this.get("host") +
                   " with an interval of " + this.get("interval") + "ms.",
                   "info", "LPDynamicDomUpdater");
 
@@ -253,15 +243,15 @@
          * @method dynamicUpdate
          */
         dynamicUpdate: function() {
-            Y.log("Starting update for " + this.get("owner"),
+            Y.log("Starting update for " + this.get("host"),
                   "info", "LP.DynamicDomUpdater");
             var uri = this.get("uri");
             var api_method_name = this.get("api_method_name");
 
             // Check whether we should stop updating now...
-            if (this.get("stopUpdatesCheckFunction")(this.get("owner"))){
+            if (this.get("stopUpdatesCheckFunction")(this.get("host"))){
                 Y.log(
-                    "Cancelling updates for " + this.get("owner") +
+                    "Cancelling updates for " + this.get("host") +
                     "after stopUpdatesCheckFunction returned true.", "info",
                     "LP DynamicDomUpdater");
                 return;
@@ -272,7 +262,7 @@
                 "parameterEvaluatorFunction");
             if (parameterEvaluatorFunction !== null){
                 this._lp_api_config.parameters = parameterEvaluatorFunction(
-                    this.get("owner"));
+                    this.get("host"));
             }
 
             // Finally, call the LP api method as required...
@@ -301,7 +291,7 @@
             var elapsed_time = new Date().getTime() - this._request_start;
             Y.log([
                 "Data received for ",
-                this.get("owner"),
+                this.get("host"),
                 " after ",
                 elapsed_time,
                 "ms."
@@ -354,7 +344,7 @@
          * @private
          */
         _handleFailure: function(id, request) {
-            Y.fail("LP.DynamicDomUpdater for " + this.get("owner") +
+            Y.fail("LP.DynamicDomUpdater for " + this.get("host") +
                    " failed to get dynamic data.");
         }
     });

=== modified file 'lib/canonical/launchpad/javascript/soyuz/tests/archivesubscribers_index.js'
--- lib/canonical/launchpad/javascript/soyuz/tests/archivesubscribers_index.js	2009-11-04 19:59:16 +0000
+++ lib/canonical/launchpad/javascript/soyuz/tests/archivesubscribers_index.js	2009-11-24 17:00:32 +0000
@@ -6,7 +6,7 @@
     filter: 'raw',
     combine: false
     }).use(
-        'yuitest', 'console', 'soyuz.archivesubscribers_index', function(Y) {
+        'test', 'console', 'soyuz.archivesubscribers_index', function(Y) {
 
 var Assert = Y.Assert;  // For easy access to isTrue(), etc.
 
@@ -114,7 +114,7 @@
         Assert.areEqual(
             '<a class="js-action sprite add" href="#">Add access</a>',
             this.add_subscriber_placeholder.get('innerHTML'),
-            "The 'Add access' link should be created during setup.")
+            "The 'Add access' link should be created during setup.");
     },
 
     test_click_add_access_displays_add_row: function() {

=== modified file 'lib/canonical/launchpad/javascript/soyuz/tests/lp_dynamic_dom_updater.js'
--- lib/canonical/launchpad/javascript/soyuz/tests/lp_dynamic_dom_updater.js	2009-07-17 00:26:05 +0000
+++ lib/canonical/launchpad/javascript/soyuz/tests/lp_dynamic_dom_updater.js	2009-11-24 17:00:32 +0000
@@ -5,7 +5,7 @@
     base: '../../../icing/yui/current/build/',
     filter: 'raw',
     combine: false
-    }).use('yuitest', 'console', 'soyuz.dynamic_dom_updater', function(Y) {
+    }).use('test', 'console', 'soyuz.dynamic_dom_updater', function(Y) {
 
 var Assert = Y.Assert;  // For easy access to isTrue(), etc.