Launchpad itself

Merge lp:~michael.nelson/launchpad/db-test-fix-timebomb into lp:launchpad/db-devel

  1. db-test-fix-timebomb
  2. Merge into db-devel
Proposed by Michael Nelson on 2010-04-01
Status: Merged
Approved by: Jeroen T. Vermeulen on 2010-04-01
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp:~michael.nelson/launchpad/db-test-fix-timebomb
Merge into: lp:launchpad/db-devel
Diff against target: 36 lines (+9/-5)
1 file modified
lib/lp/registry/stories/milestone/object-milestones.txt (+9/-5)
To merge this branch: bzr merge lp:~michael.nelson/launchpad/db-test-fix-timebomb
Reviewer Review Type Date Requested Status
Jeroen T. Vermeulen (community) 2010-04-01 Approve on 2010-04-01
Review via email: mp+22595@code.launchpad.net

Description of the Change

Don't check the actual dates when printing milestones.

To post a comment you must log in.
Jeroen T. Vermeulen (jtv) wrote :

One review change per IRC: don't mask the dates with "..." because it might hide an entire line of output. Thanks for implementing that!

review: Approve
Michael Nelson (michael.nelson) wrote :

r9187 (which is still not appearing) is http://pastebin.ubuntu.com/407482/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/registry/stories/milestone/object-milestones.txt'
2--- lib/lp/registry/stories/milestone/object-milestones.txt 2009-11-26 03:06:58 +0000
3+++ lib/lp/registry/stories/milestone/object-milestones.txt 2010-04-01 09:14:27 +0000
4@@ -11,6 +11,10 @@
5 ... return None
6 ... result = []
7 ... for tr in table.findAll('tr'):
8+ ... milestone_date = tr.find('span')
9+ ... if len(milestone_date.contents) > 0:
10+ ... # Just make sure we don't print an actual date.
11+ ... milestone_date.contents[0].replaceWith('A date')
12 ... result.append(extract_text(tr))
13 ... return '\n'.join(result)
14
15@@ -68,7 +72,7 @@
16 Mozilla Firefox 0.9.2 "One (secure) Tree Hill" trunk None ...
17 Mozilla Firefox 0.9.1 "One Tree Hill (v2)" trunk None ...
18 Mozilla Firefox 0.9 "One Tree Hill" trunk None ...
19- Mozilla Firefox 1.0 trunk 2056-10-16
20+ Mozilla Firefox 1.0 trunk A date
21 not yet released
22
23 When the project is a member of a project group, the the user can see a link
24@@ -112,10 +116,10 @@
25 >>> print all_milestones(anon_browser)
26 GNOME 2.1.6 None This is an inactive milestone
27 GNOME 1.0 None This is an inactive milestone
28- GNOME 1.3 2012-04-01 This is an inactive milestone
29- GNOME 1.2 2011-04-01 not yet released
30- GNOME 1.1. 2010-04-02 not yet released
31- GNOME 1.1 2010-04-01 not yet released Bugs targeted: 3 Confirmed
32+ GNOME 1.3 A date This is an inactive milestone
33+ GNOME 1.2 A date not yet released
34+ GNOME 1.1. A date not yet released
35+ GNOME 1.1 A date not yet released Bugs targeted: 3 Confirmed
36 Blueprints targeted: 2 Unknown
37
38

Subscribers

People subscribed via source and target branches

to status/vote changes: