Merge lp:~michael.nelson/launchpad/db-build-farm-job-model into lp:launchpad/db-devel

[Michael Nelson]

This branch is part of a pipeline for

https://blueprints.edge.launchpad.net/soyuz/+spec/build-generalisation
https://dev.launchpad.net/LEP/GeneralBuildHistories

In particular, this branch turns BuildFarmJob into a concrete class, while at the same time, continuing support temporarily for classes that still expect this to be an in-memory object.

It is dependent on the pending schema patch in a previous branch.

To test
=======

First update the test db schema (required as the db patch still needs to be updated to remove the old build table):
psql launchpad_ftest_template -f database/schema/pending/michaeln-build-generalisation.sql
bin/py database/schema/security.py -d launchpad_ftest_template

And then:
bin/test -vvt test_buildfarmjob -t doc/build.txt -t test_buildqueue -t test_sourcepackagerecipebuild -t test_translationtemplatesbuildjob

The next stage will be a similar conversion for PackageBuildFarmJob, followed by switching the BinaryPackageBuild from the old build table to the new binarypackagebuild table.

[Abel Deuring (adeuring)]

This branch is part of a pipeline for

https://blueprints.edge.launchpad.net/soyuz/+spec/build-generalisation
https://dev.launchpad.net/LEP/GeneralBuildHistories

In particular, this branch turns BuildFarmJob into a concrete class, while at the same time, continuing support temporarily for classes that still expect this to be an in-memory object.

It is dependent on the pending schema patch in a previous branch.

To test
=======

First update the test db schema (required as the db patch still needs to be updated to remove the old build table):
psql launchpad_ftest_template -f database/schema/pending/michaeln-build-generalisation.sql
bin/py database/schema/security.py -d launchpad_ftest_template

And then:
bin/test -vvt test_buildfarmjob -t doc/build.txt -t test_buildqueue -t test_sourcepackagerecipebuild -t test_translationtemplatesbuildjob

The next stage will be a similar conversion for PackageBuildFarmJob, followed by switching the BinaryPackageBuild from the old build table to the new binarypackagebuild table.

review: Approve (code)

[Abel Deuring (adeuring)]

Hi Michael,

a nice branch; just just have a few formal nitpicks.

> === modified file 'lib/lp/buildmaster/interfaces/buildfarmjob.py'
> --- lib/lp/buildmaster/interfaces/buildfarmjob.py 2010-04-21 07:15:40 +0000
> +++ lib/lp/buildmaster/interfaces/buildfarmjob.py 2010-04-22 07:42:23 +0000
> @@ -9,15 +9,20 @@
>
> __all__ = [
> 'IBuildFarmJob',
> + 'IBuildFarmJobSource',
> 'IBuildFarmJobDerived',
> 'BuildFarmJobType',
> ]
>
> from zope.interface import Interface, Attribute
> -
> -from canonical.launchpad import _
> +from zope.schema import Bool, Choice, Datetime
> from lazr.enum import DBEnumeratedType, DBItem
> from lazr.restful.fields import Reference
> +
> +from canonical.launchpad import _
> +from canonical.launchpad.interfaces.librarian import ILibraryFileAlias
> +
> +from lp.buildmaster.interfaces.builder import IBuilder
> from lp.soyuz.interfaces.processor import IProcessor
>
>
> @@ -56,6 +61,66 @@
> class IBuildFarmJob(Interface):
> """Operations that jobs for the build farm must implement."""
>
> + id = Attribute('The build farm job ID.')
> +
> + processor = Reference(
> + IProcessor, title=_("Processor"), required=False, readonly=True,
> + description=_(
> + "The Processor required by this build farm job. "
> + "For processor-independent job types please return None."))

It is perhaps my limited English knowledge, but this sounds to me
like a polite request to the implementation class to do the right
thing ;) What about "should|must be None for processor-independent jobs"?

> +
> + virtualized = Bool(
> + title=_('Virtualized'), required=False, readonly=True,
> + description=_(
> + "The virtualization setting required by this build farm job. "
> + "For job types that do not care about virtualization please "
> + "return None."))

Same here.

> +
> + date_created = Datetime(
> + title=_("Date created"), required=True, readonly=True,
> + description=_("The timestamp when the build farm job was created."))
> +
> + date_started = Datetime(
> + title=_("Date started"), required=False, readonly=True,
> + description=_("The timestamp when the build farm job was started."))
> +
> + date_finished = Datetime(
> + title=_("Date finished"), required=False, readonly=True,
> + description=_("The timestamp when the build farm job was finished."))
> +
> + date_first_dispatched = Datetime(
> + title=_("Date finished"), required=False, readonly=True,
> + description=_("The timestamp when the build farm job was finished."))

s/finished/dispatched/

> +
> + builder = Reference(
> + title=_("Builder"), schema=IBuilder, required=False, readonly=True,
> + description=_("The builder assigned to this job."))
> +
> + status = Choice(
> + title=_('Status'), required=True,
> + # Really PackagePublishingPocket, patched in

s/PackagePublishingPocket/BuildStatus/

[...]

> @@ -149,3 +202,17 @@
> accurately based on this job's properties.
> """
>
> +
> +class IBuildFarmJobSource(Interface):
> + """A utility of Build...

[Michael Nelson (michael.nelson)]

On Fri, Apr 23, 2010 at 12:53 PM, Abel Deuring
<email address hidden> wrote:
> Hi Michael,
>
> a nice branch; just just have a few formal nitpicks.

Thanks Abel, comments below.

>
>> === modified file 'lib/lp/buildmaster/interfaces/buildfarmjob.py'
>> --- lib/lp/buildmaster/interfaces/buildfarmjob.py     2010-04-21 07:15:40 +0000
>> +++ lib/lp/buildmaster/interfaces/buildfarmjob.py     2010-04-22 07:42:23 +0000
>> @@ -9,15 +9,20 @@
>>
>>  __all__ = [
>>      'IBuildFarmJob',
>> +    'IBuildFarmJobSource',
>>      'IBuildFarmJobDerived',
>>      'BuildFarmJobType',
>>      ]
>>
>>  from zope.interface import Interface, Attribute
>> -
>> -from canonical.launchpad import _
>> +from zope.schema import Bool, Choice, Datetime
>>  from lazr.enum import DBEnumeratedType, DBItem
>>  from lazr.restful.fields import Reference
>> +
>> +from canonical.launchpad import _
>> +from canonical.launchpad.interfaces.librarian import ILibraryFileAlias
>> +
>> +from lp.buildmaster.interfaces.builder import IBuilder
>>  from lp.soyuz.interfaces.processor import IProcessor
>>
>>
>> @@ -56,6 +61,66 @@
>>  class IBuildFarmJob(Interface):
>>      """Operations that jobs for the build farm must implement."""
>>
>> +    id = Attribute('The build farm job ID.')
>> +
>> +    processor = Reference(
>> +        IProcessor, title=_("Processor"), required=False, readonly=True,
>> +        description=_(
>> +            "The Processor required by this build farm job. "
>> +            "For processor-independent job types please return None."))
>
> It is perhaps my limited English knowledge, but this sounds to me
> like a polite request to the implementation class to do the right
> thing ;) What about "should|must be None for processor-independent jobs"?

Yep. This was just a copy-n-paste, but you're right. Updated.

>
>
>> +
>> +    virtualized = Bool(
>> +        title=_('Virtualized'), required=False, readonly=True,
>> +        description=_(
>> +            "The virtualization setting required by this build farm job. "
>> +            "For job types that do not care about virtualization please "
>> +            "return None."))
>
> Same here.

Ditto.

>
>> +
>> +    date_created = Datetime(
>> +        title=_("Date created"), required=True, readonly=True,
>> +        description=_("The timestamp when the build farm job was created."))
>> +
>> +    date_started = Datetime(
>> +        title=_("Date started"), required=False, readonly=True,
>> +        description=_("The timestamp when the build farm job was started."))
>> +
>> +    date_finished = Datetime(
>> +        title=_("Date finished"), required=False, readonly=True,
>> +        description=_("The timestamp when the build farm job was finished."))
>> +
>> +    date_first_dispatched = Datetime(
>> +        title=_("Date finished"), required=False, readonly=True,
>> +        description=_("The timestamp when the build farm job was finished."))
>
> s/finished/dispatched/

Done.

>
>> +
>> +    builder = Reference(
>> +        title=_("Builder"), schema=IBuilder, required=False, readonly=True,
>> +        description=_("The builder assigned to this job."))
>> +
>> +    status = Choice(
>> +        title=_('Status'...

[Jelmer Vernooij (jelmer)]

review: Abstain

=== modified file 'lib/canonical/launchpad/interfaces/_schema_circular_imports.py'
--- lib/canonical/launchpad/interfaces/_schema_circular_imports.py	2010-04-23 03:16:22 +0000
+++ lib/canonical/launchpad/interfaces/_schema_circular_imports.py	2010-05-05 15:46:51 +0000
@@ -34,6 +34,7 @@
 from lp.bugs.interfaces.bugtracker import IBugTracker
 from lp.bugs.interfaces.bugwatch import IBugWatch
 from lp.buildmaster.interfaces.buildbase import BuildStatus
+from lp.buildmaster.interfaces.buildfarmjob import IBuildFarmJob
 from lp.soyuz.interfaces.binarypackagebuild import IBinaryPackageBuild
 from lp.soyuz.interfaces.buildrecords import IHasBuildRecords
 from lp.blueprints.interfaces.specification import ISpecification
@@ -271,6 +272,10 @@
 patch_plain_parameter_type(
     IArchive, 'deletePackagesetUploader', 'packageset', IPackageset)
 
+
+# IBuildFarmJob
+IBuildFarmJob['status'].vocabulary = BuildStatus
+
 # IDistribution
 IDistribution['series'].value_type.schema = IDistroSeries
 patch_reference_property(

=== modified file 'lib/lp/buildmaster/configure.zcml'
--- lib/lp/buildmaster/configure.zcml	2010-03-05 13:52:32 +0000
+++ lib/lp/buildmaster/configure.zcml	2010-05-05 15:46:51 +0000
@@ -42,6 +42,21 @@
         permission="zope.Public"/>
 
 
+    <!-- BuildFarmJob -->
+    <class
+        class="lp.buildmaster.model.buildfarmjob.BuildFarmJob">
+        <allow
+            interface="lp.buildmaster.interfaces.buildfarmjob.IBuildFarmJob" />
+    </class>
+    <securedutility
+        component="lp.buildmaster.model.buildfarmjob.BuildFarmJob"
+        provides="lp.buildmaster.interfaces.buildfarmjob.IBuildFarmJobSource">
+
+        <allow
+            interface="lp.buildmaster.interfaces.buildfarmjob.IBuildFarmJobSource" />
+    </securedutility>
+
+
     <!-- BuildQueue -->
     <class
         class="lp.buildmaster.model.buildqueue.BuildQueue">

=== modified file 'lib/lp/buildmaster/interfaces/buildfarmjob.py'
--- lib/lp/buildmaster/interfaces/buildfarmjob.py	2010-04-28 08:24:54 +0000
+++ lib/lp/buildmaster/interfaces/buildfarmjob.py	2010-05-05 15:46:51 +0000
@@ -9,15 +9,20 @@
 
 __all__ = [
     'IBuildFarmJob',
+    'IBuildFarmJobSource',
     'IBuildFarmJobDerived',
     'BuildFarmJobType',
     ]
 
 from zope.interface import Interface, Attribute
-
-from canonical.launchpad import _
+from zope.schema import Bool, Choice, Datetime
 from lazr.enum import DBEnumeratedType, DBItem
 from lazr.restful.fields import Reference
+
+from canonical.launchpad import _
+from canonical.launchpad.interfaces.librarian import ILibraryFileAlias
+
+from lp.buildmaster.interfaces.builder import IBuilder
 from lp.soyuz.interfaces.processor import IProcessor
 
 
@@ -56,6 +61,66 @@
 class IBuildFarmJob(Interface):
     """Operations that jobs for the build farm must implement."""
 
+    id = Attribute('The build farm job ID.')
+
+    processor = Reference(
+        IProcessor, title=_("Processor"), required=False, readonly=True,
+        description=_(
+            "The Processor required by this build farm job. "
+            "This should be None for processor-independent job types."))
+
+    virtualized = Bool(
+        title=_('Virtualized'), required=False, readonly=True,
+        description=_(
+            "The virtualization setting required by this build farm job. "
+            "This should be None for job types that do not care whether "
+            "they run virtualized."))
+
+    date_created = Datetime(
+        title=_("Date created"), required=True, readonly=True,
+        description=_("The timestamp when the build farm job was created."))
+
+    date_started = Datetime(
+        title=_("Date started"), required=False, readonly=True,
+        description=_("The timestamp when the build farm job was started."))
+
+    date_finished = Datetime(
+        title=_("Date finished"), required=False, readonly=True,
+        description=_("The timestamp when the build farm job was finished."))
+
+    date_first_dispatched = Datetime(
+        title=_("Date finished"), required=False, readonly=True,
+        description=_("The timestamp when the build farm job was dispatched."))
+
+    builder = Reference(
+        title=_("Builder"), schema=IBuilder, required=False, readonly=True,
+        description=_("The builder assigned to this job."))
+
+    status = Choice(
+        title=_('Status'), required=True,
+        # Really BuildStatus, patched in
+        # _schema_circular_imports.py
+        vocabulary=DBEnumeratedType,
+        description=_("The current status of the job."))
+
+    log = Reference(
+        schema=ILibraryFileAlias, required=False,
+        title=_(
+            "The LibraryFileAlias containing the entire log for this job."))
+
+    job_type = Choice(
+        title=_("Job type"), required=True, readonly=True,
+        vocabulary=BuildFarmJobType,
+        description=_("The specific type of job."))
+
+    # XXX 2010-04-21 michael.nelson bug=567922. This property
+    # can be removed once all *Build classes use the concrete
+    # BuildFarmJob.
+    has_concrete_build_farm_job = Bool(
+        title=_('Has concrete build farm job'), required=False,
+        readonly=True, description=_(
+            'Whether this instance is or has a concrete build farm job.'))
+
     def score():
         """Calculate a job score appropriate for the job type in question."""
 
@@ -77,18 +142,6 @@
     def jobAborted():
         """'Job aborted' life cycle event, handle as appropriate."""
 
-    processor = Reference(
-        IProcessor, title=_("Processor"),
-        description=_(
-            "The Processor required by this build farm job. "
-            "For processor-independent job types please return None."))
-
-    virtualized = Attribute(
-        _(
-            "The virtualization setting required by this build farm job. "
-            "For job types that do not care about virtualization please "
-            "return None."))
-
 
 class IBuildFarmJobDerived(Interface):
     """Common functionality required by classes delegating IBuildFarmJob.
@@ -151,3 +204,18 @@
 
     def cleanUp():
         """Job's finished.  Delete its supporting data."""
+
+
+class IBuildFarmJobSource(Interface):
+    """A utility of BuildFarmJob used to create _things_."""
+
+    def new(job_type, status=None, processor=None,
+            virtualized=None):
+        """Create a new `IBuildFarmJob`.
+
+        :param job_type: A `BuildFarmJobType` item.
+        :param status: A `BuildStatus` item, defaulting to PENDING.
+        :param processor: An optional processor for this job.
+        :param virtualized: An optional boolean indicating whether
+            this job should be run virtualized.
+        """

=== modified file 'lib/lp/buildmaster/model/buildfarmjob.py'
--- lib/lp/buildmaster/model/buildfarmjob.py	2010-04-28 08:24:54 +0000
+++ lib/lp/buildmaster/model/buildfarmjob.py	2010-05-05 15:46:51 +0000
@@ -12,23 +12,93 @@
 
 from lazr.delegates import delegates
 
+import hashlib
+import pytz
+
+from storm.info import get_obj_info
+from storm.locals import Bool, DateTime, Int, Reference, Storm
+from storm.store import Store
+
 from zope.component import getUtility
-from zope.interface import implements
+from zope.interface import classProvides, implements
 from zope.security.proxy import removeSecurityProxy
 
-from storm.store import Store
-
+from canonical.database.constants import UTC_NOW
+from canonical.database.enumcol import DBEnum
+from canonical.launchpad.interfaces.lpstorm import IMasterStore
 from canonical.launchpad.webapp.interfaces import (
     DEFAULT_FLAVOR, IStoreSelector, MAIN_STORE)
 
+from lp.buildmaster.interfaces.buildbase import BuildStatus
 from lp.buildmaster.interfaces.buildfarmjob import (
-    IBuildFarmJob, IBuildFarmJobDerived)
+    BuildFarmJobType, IBuildFarmJob, IBuildFarmJobDerived,
+    IBuildFarmJobSource)
 from lp.buildmaster.interfaces.buildqueue import IBuildQueueSet
 
 
-class BuildFarmJob:
+class BuildFarmJob(Storm):
     """A base implementation for `IBuildFarmJob` classes."""
+
+    __storm_table__ = 'BuildFarmJob'
+
     implements(IBuildFarmJob)
+    classProvides(IBuildFarmJobSource)
+
+    id = Int(primary=True)
+
+    processor_id = Int(name='processor', allow_none=True)
+    processor = Reference(processor_id, 'Processor.id')
+
+    virtualized = Bool()
+
+    date_created = DateTime(
+        name='date_created', allow_none=False, tzinfo=pytz.UTC)
+
+    date_started = DateTime(
+        name='date_started', allow_none=True, tzinfo=pytz.UTC)
+
+    date_finished = DateTime(
+        name='date_finished', allow_none=True, tzinfo=pytz.UTC)
+
+    date_first_dispatched = DateTime(
+        name='date_first_dispatched', allow_none=True, tzinfo=pytz.UTC)
+
+    builder_id = Int(name='builder', allow_none=True)
+    builder = Reference(builder_id, 'Builder.id')
+
+    status = DBEnum(name='status', allow_none=False, enum=BuildStatus)
+
+    log_id = Int(name='log', allow_none=True)
+    log = Reference(log_id, 'LibraryFileAlias.id')
+
+    job_type = DBEnum(
+        name='job_type', allow_none=False, enum=BuildFarmJobType)
+
+    def __init__(self, job_type, status=BuildStatus.NEEDSBUILD,
+                 processor=None, virtualized=None):
+        self.job_type, self.status, self.process, self.virtualized = (
+            job_type,
+            status,
+            processor,
+            virtualized,
+            )
+
+    @classmethod
+    def new(cls, job_type, status=BuildStatus.NEEDSBUILD, processor=None,
+            virtualized=None):
+        """See `IBuildFarmJobSource`."""
+        build_farm_job = BuildFarmJob(
+            job_type, status, processor, virtualized)
+
+        store = IMasterStore(BuildFarmJob)
+        store.add(build_farm_job)
+        return build_farm_job
+
+    @property
+    def has_concrete_build_farm_job(self):
+        """See `IBuildFarmJob`."""
+        # Check if the object has been added to the store.
+        return get_obj_info(self).get('store') is not None
 
     def score(self):
         """See `IBuildFarmJob`."""
@@ -48,25 +118,34 @@
 
     def jobStarted(self):
         """See `IBuildFarmJob`."""
-        pass
+        if not self.has_concrete_build_farm_job:
+            return
+        self.status = BuildStatus.BUILDING
+        # The build started, set the start time if not set already.
+        self.date_started = UTC_NOW
+        if self.date_first_dispatched is None:
+            self.date_first_dispatched = UTC_NOW
 
     def jobReset(self):
         """See `IBuildFarmJob`."""
-        pass
-
-    def jobAborted(self):
-        """See `IBuildFarmJob`."""
-        pass
-
-    @property
-    def processor(self):
-        """See `IBuildFarmJob`."""
-        return None
-
-    @property
-    def virtualized(self):
-        """See `IBuildFarmJob`."""
-        return None
+        if not self.has_concrete_build_farm_job:
+            return
+        self.status = BuildStatus.NEEDSBUILD
+        self.date_started = None
+
+    # The implementation of aborting a job is the same as resetting
+    # a job.
+    jobAborted = jobReset
+
+    @staticmethod
+    def addCandidateSelectionCriteria(processor, virtualized):
+        """See `IBuildFarmJob`."""
+        return ('')
+
+    @staticmethod
+    def postprocessCandidate(job, logger):
+        """See `IBuildFarmJob`."""
+        return True
 
 
 class BuildFarmJobDerived:
@@ -92,7 +171,8 @@
 
         Sub-classes can override as required.
         """
-        self._build_farm_job = BuildFarmJob()
+        self._build_farm_job = BuildFarmJob(
+            job_type=BuildFarmJobType.PACKAGEBUILD)
 
     @classmethod
     def getByJob(cls, job):

=== modified file 'lib/lp/buildmaster/model/packagebuildfarmjob.py'
--- lib/lp/buildmaster/model/packagebuildfarmjob.py	2010-04-28 08:24:54 +0000
+++ lib/lp/buildmaster/model/packagebuildfarmjob.py	2010-05-05 15:46:51 +0000
@@ -26,7 +26,9 @@
         itself a concrete class. This class (PackageBuildFarmJob)
         will also be renamed PackageBuild and turned into a concrete class.
         """
-        super(PackageBuildFarmJob, self).__init__()
+        # Classes that initialise with a build are not yet using
+        # the concrete class, so we don't call the superclass'
+        # initialisation.
         self.build = build
 
     def getTitle(self):

=== added file 'lib/lp/buildmaster/tests/test_buildfarmjob.py'
--- lib/lp/buildmaster/tests/test_buildfarmjob.py	1970-01-01 00:00:00 +0000
+++ lib/lp/buildmaster/tests/test_buildfarmjob.py	2010-05-05 15:46:51 +0000
@@ -0,0 +1,120 @@
+# Copyright 2010 Canonical Ltd.  This software is licensed under the
+# GNU Affero General Public License version 3 (see the file LICENSE).
+
+"""Tests for `IBuildFarmJob`."""
+
+__metaclass__ = type
+
+import unittest
+
+from storm.store import Store
+from zope.component import getUtility
+
+from canonical.database.sqlbase import flush_database_updates
+from canonical.testing.layers import DatabaseFunctionalLayer
+
+from lp.buildmaster.interfaces.buildbase import BuildStatus
+from lp.buildmaster.interfaces.buildfarmjob import (
+    BuildFarmJobType, IBuildFarmJob, IBuildFarmJobSource)
+from lp.buildmaster.model.buildfarmjob import BuildFarmJob
+from lp.testing import TestCaseWithFactory
+
+
+class TestBuildFarmJob(TestCaseWithFactory):
+    """Tests for the build farm job object."""
+
+    layer = DatabaseFunctionalLayer
+
+    def setUp(self):
+        """Create a build farm job with which to test."""
+        super(TestBuildFarmJob, self).setUp()
+        self.build_farm_job = self.makeBuildFarmJob()
+
+    def makeBuildFarmJob(self):
+        return getUtility(IBuildFarmJobSource).new(
+            job_type=BuildFarmJobType.PACKAGEBUILD)
+
+    def test_has_concrete_build_farm_job(self):
+        # This temporary property returns true if the instance
+        # corresponds to a concrete database record, even if
+        # db updates have not yet been flushed, and false
+        # otherwise.
+        concrete_build_farm_job = self.makeBuildFarmJob()
+        self.failUnless(concrete_build_farm_job.has_concrete_build_farm_job)
+
+        mem_build_farm_job = BuildFarmJob(
+            job_type=BuildFarmJobType.PACKAGEBUILD)
+        self.failIf(mem_build_farm_job.has_concrete_build_farm_job)
+
+    def test_providesInterface(self):
+        # BuildFarmJob provides IBuildFarmJob
+        self.assertProvides(self.build_farm_job, IBuildFarmJob)
+
+    def test_saves_record(self):
+        # A build farm job can be stored in the database.
+        flush_database_updates()
+        store = Store.of(self.build_farm_job)
+        retrieved_job = store.find(
+            BuildFarmJob,
+            BuildFarmJob.id == self.build_farm_job.id).one()
+        self.assertEqual(self.build_farm_job, retrieved_job)
+
+    def test_default_values(self):
+        # A build farm job defaults to the NEEDSBUILD status.
+        # We flush the database updates to ensure sql defaults
+        # are set for various attributes.
+        flush_database_updates()
+        self.assertEqual(
+            BuildStatus.NEEDSBUILD, self.build_farm_job.status)
+        # The date_created is set automatically.
+        self.assertTrue(self.build_farm_job.date_created is not None)
+        # The job type is required to create a build farm job.
+        self.assertEqual(
+            BuildFarmJobType.PACKAGEBUILD, self.build_farm_job.job_type)
+        # Other attributes are unset by default.
+        self.assertEqual(None, self.build_farm_job.processor)
+        self.assertEqual(None, self.build_farm_job.virtualized)
+        self.assertEqual(None, self.build_farm_job.date_started)
+        self.assertEqual(None, self.build_farm_job.date_finished)
+        self.assertEqual(None, self.build_farm_job.date_first_dispatched)
+        self.assertEqual(None, self.build_farm_job.builder)
+        self.assertEqual(None, self.build_farm_job.log)
+
+    def test_unimplemented_methods(self):
+        # A build farm job leaves the implementation of various
+        # methods for derived classes.
+        self.assertRaises(NotImplementedError, self.build_farm_job.score)
+        self.assertRaises(NotImplementedError, self.build_farm_job.getName)
+        self.assertRaises(NotImplementedError, self.build_farm_job.getTitle)
+
+    def test_jobStarted(self):
+        # Starting a job sets the date_started and status, as well as
+        # the date first dispatched, if it is the first dispatch of
+        # this job.
+        self.build_farm_job.jobStarted()
+        self.assertTrue(self.build_farm_job.date_first_dispatched is not None)
+        self.assertTrue(self.build_farm_job.date_started is not None)
+        self.assertEqual(
+            BuildStatus.BUILDING, self.build_farm_job.status)
+
+    def test_jobReset(self):
+        # Resetting a job sets its status back to NEEDSBUILD and unsets
+        # the date_started.
+        self.build_farm_job.jobStarted()
+        self.build_farm_job.jobReset()
+        self.failUnlessEqual(
+            BuildStatus.NEEDSBUILD, self.build_farm_job.status)
+        self.failUnless(self.build_farm_job.date_started is None)
+
+    def test_jobAborted(self):
+        # Aborting a job sets its status back to NEEDSBUILD and unsets
+        # the date_started.
+        self.build_farm_job.jobStarted()
+        self.build_farm_job.jobAborted()
+        self.failUnlessEqual(
+            BuildStatus.NEEDSBUILD, self.build_farm_job.status)
+        self.failUnless(self.build_farm_job.date_started is None)
+
+
+def test_suite():
+    return unittest.TestLoader().loadTestsFromName(__name__)