Merge lp:~michael.nelson/launchpad/635005-difference-details-1 into lp:launchpad/db-devel
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Māris Fogels | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 9788 | ||||
Proposed branch: | lp:~michael.nelson/launchpad/635005-difference-details-1 | ||||
Merge into: | lp:launchpad/db-devel | ||||
Diff against target: |
503 lines (+326/-23) 13 files modified
lib/lp/registry/browser/configure.zcml (+11/-0) lib/lp/registry/browser/distroseries.py (+5/-0) lib/lp/registry/browser/distroseriesdifference.py (+29/-0) lib/lp/registry/browser/tests/test_distroseriesdifference_views.py (+172/-0) lib/lp/registry/browser/tests/test_sourcepackage_views.py (+1/-1) lib/lp/registry/configure.zcml (+2/-1) lib/lp/registry/interfaces/distroseriesdifference.py (+10/-0) lib/lp/registry/model/distroseriesdifference.py (+11/-0) lib/lp/registry/stories/packaging/xx-sourcepackage-packaging.txt (+1/-1) lib/lp/registry/templates/distroseriesdifference-listing-extra.pt (+34/-0) lib/lp/registry/tests/test_distroseriesdifference.py (+11/-0) lib/lp/soyuz/tests/test_publishing.py (+22/-20) lib/lp/testing/factory.py (+17/-0) |
||||
To merge this branch: | bzr merge lp:~michael.nelson/launchpad/635005-difference-details-1 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Māris Fogels (community) | Approve | ||
Review via email: mp+35408@code.launchpad.net |
Commit message
Adds template snippet and view for DistroSeriesDif
Description of the change
Overview
========
This is the first branch to address bug 635005 - adding a template snippet with details about a DistroSeriesDif
It continues the work that began (and landed behind a feature flag) at:
https:/
which is working towards this UI: https:/
Details
=======
The branch:
* Adds a traversal for a DistroSeriesDif
for the extra details dropdown.
* The above required a new getter method, IDistroSeriesDi
* Testing the view required updating a soyuz helper method that creates binaries with summaries so that the summary for the source is displayed.
* Testing the view also required adding a new factory method makePackageDiff().
I've put the template tests in a unit test, I hope that's ok. If you think it's necessary, I can add a story with the next branch that shows the non-js behaviour (ie. this page will display when users click on the first column of the list shown at: http://
To demo:
========
You'll need to run the following in a harness:
http://
and then you can see the raw snippet at:
https:/
which should look like this: https:/
(in retrospect, that script could be shortened and used the new helpers in the branch that I created since creating the script).
To test:
========
bin/test -vv -m test_distroseri
Up next will be a second branch which adds the comments to the snippet and before connecting it up with the JS dropdown. As this won't be styled until its seen in the context of the dropdown, I'll request a ui-review for that branch.
Hi Michael,
This looks great! r=mars
Maris