Merge lp:~michael.nelson/launchpad/434000-copy-archive-ui into lp:launchpad

Proposed by Michael Nelson on 2009-09-21
Status: Merged
Approved by: Brad Crittenden on 2009-09-21
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp:~michael.nelson/launchpad/434000-copy-archive-ui
Merge into: lp:launchpad
Diff against target: None lines
To merge this branch: bzr merge lp:~michael.nelson/launchpad/434000-copy-archive-ui
Reviewer Review Type Date Requested Status
Barry Warsaw (community) ui* Approve on 2009-09-21
Brad Crittenden (community) release-critical 2009-09-21 Approve on 2009-09-21
Aaron Bentley (community) 2009-09-21 Approve on 2009-09-21
Review via email: mp+12164@code.launchpad.net
To post a comment you must log in.
Michael Nelson (michael.nelson) wrote :

= Summary =

When we updated the archive index for the ppa page, the distribution
copy archive page was also updated - it had some performance issues
which were only just fixed, exposing an ugly ui issue.

http://people.canonical.com/~michaeln/tmp/before-copy-archive.png

This branch updates the page to look like:

http://people.canonical.com/~michaeln/tmp/after-copy-archive.png

== Proposed fix ==

Simply omit the yui-gc (2/3 - 1/3) column layout for copy archives.

This leaves the page readable. But we'll require further ui work -
possibly a separate template for copy-archive indexes - during a later
cycle.

== Pre-implementation notes ==

== Implementation details ==

== Tests ==
bin/test -vv -t stories/ppa -t stories/soyuz

== Demo and Q/A ==
To demo locally, in a harness do:

{{{
ubuntu = getUtility(IDistributionSet)['ubuntu']
loc = factory.makeCopyArchiveLocation(distribution=ubuntu)

cprov = getUtility(IPersonSet).getByName('cprov')
ppa = cprov.archive
req = ppa.requestPackageCopy(loc, cprov)
import transaction;transaction.commit()
}}}

For QA, view:
https://edge.launchpad.net/ubuntu/+archive/test-rebuild-20090909

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/soyuz/templates/archive-macros.pt
  lib/lp/soyuz/templates/archive-index.pt

--
Michael

Aaron Bentley (abentley) :
review: Approve
Michael Nelson (michael.nelson) wrote :

BTW: the related bug is bug 434000

Brad Crittenden (bac) :
review: Approve (release-critical)
Barry Warsaw (barry) wrote :

Nice fix, thanks!

review: Approve (ui*)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/soyuz/templates/archive-index.pt'
2--- lib/lp/soyuz/templates/archive-index.pt 2009-09-18 15:06:26 +0000
3+++ lib/lp/soyuz/templates/archive-index.pt 2009-09-21 14:45:36 +0000
4@@ -38,7 +38,7 @@
5 <metal:ppa-install
6 use-macro="template/macros/ppa-upload-hint-portlet" />
7
8- <div class="yui-gc">
9+ <div class="yui-gc" tal:omit-tag="context/is_copy">
10
11 <div class="yui-u first">
12 <tal:ppa-install tal:condition="context/is_ppa">
13@@ -55,14 +55,11 @@
14 <metal:ppa-statistics-portlet
15 use-macro="template/macros/ppa-statistics-portlet" />
16 </div>
17-
18- <metal:ppa-simplified-packages-portlet
19- use-macro="template/macros/ppa-simplified-packages-portlet" />
20-
21 </div><!-- yui-gc -->
22
23-
24- </tal:main>
25+ <metal:ppa-simplified-packages-portlet
26+ use-macro="template/macros/ppa-simplified-packages-portlet" />
27+ </tal:main>
28
29 <tal:side metal:fill-slot="side">
30 <tal:menu replace="structure view/@@+global-actions" />
31
32=== modified file 'lib/lp/soyuz/templates/archive-macros.pt'
33--- lib/lp/soyuz/templates/archive-macros.pt 2009-09-10 19:03:13 +0000
34+++ lib/lp/soyuz/templates/archive-macros.pt 2009-09-21 14:45:36 +0000
35@@ -219,7 +219,7 @@
36 </p>
37
38 <tal:request_list tal:condition="requests">
39- <table id="package-requests"
40+ <table id="package-requests" class="listing"
41 tal:attributes="summary
42 string:Package copy requests for ${context/name}">
43 <thead>