Merge lp:~michael.nelson/launchpad/430459-link-build-failures-updates-portlet into lp:launchpad

[Michael Nelson]

[Michael Nelson (michael.nelson)]

= Summary =

This branch fixes bug 430459 by ensuring that if the Latest updates
portlet on the PPA page displays a failure, that the relevant failed
builds are listed and linked (unobtrusively).

See:
http://people.canonical.com/~michaeln/tmp/linked_failed_build.png

== Proposed fix ==

== Pre-implementation notes ==

See bug 430459.

== Implementation details ==

== Tests ==
bin/test -vv -t archive-views.txt -t xx-ubuntu-ppas.txt

== Demo and Q/A ==

Demo:
https://launchpad.dev/~cprov/+archive/ppa

QA: check a ppa with a recent failed build on edge.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/soyuz/stories/ppa/xx-ubuntu-ppas.txt
  lib/lp/soyuz/browser/tests/archive-views.txt
  lib/lp/soyuz/templates/archive-macros.pt
  lib/canonical/launchpad/icing/style-3-0.css
  lib/lp/soyuz/browser/archive.py

--
Michael

[Abel Deuring (adeuring)]

nice branch!

review: Approve

[Eleanor Berger (intellectronica)]

ui=me*

The change looks really great. We've discussed on IRC how the failed build icon reuses the same metaphor the remove icon uses and agreed to talk to Martin about it - maybe it's worth trying to adress that in a later branch.

review: Approve (ui*)

=== modified file 'lib/canonical/launchpad/icing/style-3-0.css'
--- lib/canonical/launchpad/icing/style-3-0.css	2009-10-15 12:39:00 +0000
+++ lib/canonical/launchpad/icing/style-3-0.css	2009-10-16 12:00:32 +0000
@@ -697,7 +697,7 @@
 
 /* For the Latest updates portlet
  * at https://launchpad.dev/~cprov/+archive/ppa */
-ul.latest-ppa-updates .duration {
+ul.latest-ppa-updates .duration, ul.latest-ppa-updates .build-details {
     font-size: 75%;
 }
 ul.latest-ppa-updates li {

=== modified file 'lib/lp/soyuz/browser/archive.py'
--- lib/lp/soyuz/browser/archive.py	2009-10-12 17:10:54 +0000
+++ lib/lp/soyuz/browser/archive.py	2009-10-16 12:00:32 +0000
@@ -62,7 +62,7 @@
 from lp.soyuz.interfaces.archivesubscriber import (
     IArchiveSubscriberSet)
 from lp.soyuz.interfaces.build import (
-    BuildStatus, IBuildSet)
+    BuildStatus, BuildSetStatus, IBuildSet)
 from lp.soyuz.interfaces.buildrecords import IHasBuildRecords
 from lp.soyuz.interfaces.component import IComponentSet
 from lp.registry.interfaces.distroseries import DistroSeriesStatus
@@ -817,21 +817,29 @@
             'FULLYBUILT': 'Successfully built',
             'FULLYBUILT_PENDING': 'Successfully built',
             'NEEDSBUILD': 'Waiting to build',
-            'FAILEDTOBUILD': 'Failed to build',
+            'FAILEDTOBUILD': 'Failed to build:',
             'BUILDING': 'Currently building',
             }
 
         now = datetime.now(tz=pytz.UTC)
         for result_tuple in result_tuples:
             source_pub = result_tuple[0]
-            current_status = source_pub.getStatusSummaryForBuilds()['status']
+            status_summary = source_pub.getStatusSummaryForBuilds()
+            current_status = status_summary['status']
             duration = now - source_pub.datepublished
 
+            # We'd like to include the builds in the latest updates
+            # iff the build failed.
+            builds = []
+            if current_status == BuildSetStatus.FAILEDTOBUILD:
+                builds = status_summary['builds']
+
             latest_updates_list.append({
                 'title': source_pub.source_package_name,
                 'status': status_names[current_status.title],
                 'status_class': current_status.title,
                 'duration': duration,
+                'builds': builds
                 })
 
         return latest_updates_list

=== modified file 'lib/lp/soyuz/browser/tests/archive-views.txt'
--- lib/lp/soyuz/browser/tests/archive-views.txt	2009-10-05 18:29:12 +0000
+++ lib/lp/soyuz/browser/tests/archive-views.txt	2009-10-16 12:00:32 +0000
@@ -304,16 +304,18 @@
     >>> login(ANONYMOUS)
 
 The ArchiveView also provides the latest updates ordered by the date
-they were published:
+they were published. We include any relevant builds for failures.
 
     >>> def print_latest_updates(latest_updates):
     ...     for update in latest_updates:
-    ...         print "%s - %s" % (
+    ...         arch_tags = [build.arch_tag for build in update['builds']]
+    ...         print "%s - %s %s" % (
     ...             update['title'],
-    ...             update['status']
+    ...             update['status'],
+    ...             " ".join(arch_tags),
     ...             )
     >>> print_latest_updates(view.latest_updates)
-    cdrkit - Failed to build
+    cdrkit - Failed to build: i386
     pmount - Successfully built
     iceweasel - Successfully built
 
@@ -326,7 +328,7 @@
     >>> login(ANONYMOUS)
     >>> print_latest_updates(view.latest_updates)
     iceweasel - Successfully built
-    cdrkit - Failed to build
+    cdrkit - Failed to build: i386
     pmount - Successfully built
 
 The ArchiveView also includes a helper method to return the number of

=== modified file 'lib/lp/soyuz/stories/ppa/xx-ubuntu-ppas.txt'
--- lib/lp/soyuz/stories/ppa/xx-ubuntu-ppas.txt	2009-10-14 17:05:14 +0000
+++ lib/lp/soyuz/stories/ppa/xx-ubuntu-ppas.txt	2009-10-16 12:00:32 +0000
@@ -371,7 +371,7 @@
     >>> print extract_text(latest_updates)
     Latest updates
     cdrkit ... ago
-    Failed to build
+    Failed to build: i386
     pmount ... ago
     Successfully built
     iceweasel ... ago

=== modified file 'lib/lp/soyuz/templates/archive-macros.pt'
--- lib/lp/soyuz/templates/archive-macros.pt	2009-09-21 14:45:36 +0000
+++ lib/lp/soyuz/templates/archive-macros.pt	2009-10-16 12:00:32 +0000
@@ -371,6 +371,12 @@
             ago
           </span><br />
           <span tal:replace="update/status">Successful</span>
+          <span tal:condition="update/builds"
+                class="build-details">
+            <a tal:repeat="build update/builds"
+               tal:attributes="href build/fmt:url"
+               tal:content="build/arch_tag">i386</a>
+          </span>
         </li>
       </ul>
     </tal:updates>