lp:~michael.nelson/juju-core/1205466-remove-charm-on-destroy-service

Branch merges

Propose for merging

No branches dependent on this one.

On hold for merging into lp:~go-bot/juju-core/trunk

Juju Engineering: Pending requested 2013-08-07

Diff: 87 lines (+40/-0)

4 files modified

state/charm.go (+18/-0)
state/conn_test.go (+4/-0)
state/service.go (+2/-0)
state/service_test.go (+16/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

1610. By Michael Nelson on 2013-08-07

GREEN: charms are deleted from state with destroy service.

1609. By Michael Nelson on 2013-08-07

RED: charms are deleted from state with destroy service.

1608. By Jeroen T. Vermeulen on 2013-08-07

[r=jtv] Set realistic endpoint in storage URL test.

We're just landing a change in gwacl that sets a fake endpoint URL in NewTestStorageContext, but that upsets this test which expects a hard-coded realistic URL.

Since the test expects a specific URL, it should make sure that the basis for that URL is clearly defined in the test -- not hidden away in a helper somewhere.

1607. By Michael Nelson on 2013-08-06

[r=dimitern],[bug=1208491] init will write the environments.yaml by default.

Changes the behaviour of the command so that:
 1. By default it will create the environments.yaml if it doesn't exist.
 2. If environments.yaml already exists, it errors appropriately (with hint about -f)
 3. If -f is provided, it will overwrite the existing environments.yaml
 4. If --show is used, it will instead print the boilerplate to stdout.

https://codereview.appspot.com/12469044/

R=dimitern, rogpeppe
R=dimitern, michael.nelson, rogpeppe

1606. By Jeroen T. Vermeulen on 2013-08-06

[r=jtv] Obtain Azure simplestreams endpoint from gwacl.

This matches an incompatible API change in gwacl r213. It asks gwacl for the right API endpoint to pass to simplestreams (China has a different one to the rest of the world) and removes the old hard-coded URL.

I also discovered to my embarrassment that getEndpoint was implemented twice: once as a method and once as a stand-alone function. The latter is all that's needed, and there's not much reason for the former. The tests turned out much simpler than originally envisaged.

1605. By Sidnei da Silva on 2013-08-06

[r=sidnei] Fix default perms on apt config

Installing the config with mode 0600 makes it impossible for a non-root user
to run any apt command.

https://codereview.appspot.com/12510043/

R=axwalk, thumper

1604. By Andrew Wilkins on 2013-08-06

[r=axwalk],[bug=1121914] cmd/juju: confirm destroy-environment

Fixes bug 1121914

https://codereview.appspot.com/12158043/

1603. By Sidnei da Silva on 2013-08-05

[r=sidnei],[bug=1203816] Fetch apt proxy config via host apt-config

Since we're passing custom userdata to the ubuntu-cloud lxc template, it ends
up not setting the apt_mirror to the MIRROR setting. Read apt proxy
configuration from the container's host instead via the apt-config command and
inject that into the container via apt_proxy cloud init setting for the http
proxy plus a runcmd that writes /etc/apt/apt.conf.d/99proxy-extra with the
same config as the host for the remaing settings not supported explicitly by
cloud-init at the moment.

https://codereview.appspot.com/12143043/

R=dimitern, rogpeppe, smoser

1602. By Dimiter Naydenov on 2013-08-05

[r=dimitern] apiserver: common AgentEntityWatcher mixin

Last step of Machiner API refactoring - extracted
the Watch method as a reusable AgentEntityWatcher
mixin and changed the machiner to use it. It will
be used by the upcoming Uniter API as well.

https://codereview.appspot.com/12464043/

R=gz, rogpeppe

1601. By Dimiter Naydenov on 2013-08-05

[r=dimitern] apiserver/common: DeadEnsurer + Machiner use it

Next step of extracing common API code, used by
the machiner and will be used by the uniter.
This introduces DeadEnsurer for entities with
EnsureDead method.

https://codereview.appspot.com/12461043/

R=gz, rogpeppe