Merge lp:~michael.nelson/charms/trusty/logstash/logstash2 into lp:~canonical-is-sa/charms/trusty/logstash/logstash2

Proposed by Michael Nelson
Status: Merged
Merged at revision: 55
Proposed branch: lp:~michael.nelson/charms/trusty/logstash/logstash2
Merge into: lp:~canonical-is-sa/charms/trusty/logstash/logstash2
Diff against target: 54 lines (+7/-7)
4 files modified
config.yaml (+3/-3)
templates/input-file-syslog.conf (+1/-1)
templates/input-redis.conf (+1/-1)
templates/output-elasticsearch.conf (+2/-2)
To merge this branch: bzr merge lp:~michael.nelson/charms/trusty/logstash/logstash2
Reviewer Review Type Date Requested Status
Michael Foley (community) Approve
Review via email: mp+276607@code.launchpad.net

Commit message

Support logstash2.0

Description of the change

Required changes to get logstash2 operational in my ELK deployment:

* Remove sincedb_path so that default is used (errors as is as it is checked for a valid path to a file, currently it's a path to a dir)

* Remove message_format from redis input - no longer available.

* elasticsearch_http no longer a plugin, instead, elasticsearch plugin is http. Also, no longer has "host" option, only "hosts"

* Updated default values to use logstash2

Verified this results in a successful spec run using https://code.launchpad.net/~michael.nelson/canonical-mojo-specs/mojo-is-logging-kibana-4/+merge/276487

To post a comment you must log in.
Revision history for this message
Michael Foley (foli) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'config.yaml'
2--- config.yaml 2015-09-29 19:30:00 +0000
3+++ config.yaml 2015-11-04 00:28:08 +0000
4@@ -1,11 +1,11 @@
5 options:
6 logstash-source:
7 type: string
8- default: "https://download.elasticsearch.org/logstash/logstash/logstash-1.4.2.tar.gz"
9+ default: "https://download.elastic.co/logstash/logstash/logstash-2.0.0.tar.gz"
10 description: The logstash binary file to install to this charm.
11 logstash-sum:
12 type: string
13- default: "d59ef579c7614c5df9bd69cfdce20ed371f728ff"
14+ default: "f0961520dd9590d3b600c877be66f79f94a05f80"
15 description: The checksum value for the logstash file.
16 extra-packages:
17 type: string
18@@ -40,7 +40,7 @@
19 A comma-separated list of nagios servicegroups.
20 If left empty, the nagios_context will be used as the servicegroup
21 nagios_check_procs_params:
22- default: "-a /opt/logstash/lib/logstash/runner.rb -c 1:1"
23+ default: "-a logstash/runner.rb -c 1:1"
24 type: string
25 description: The parameters to pass to the nrpe plugin check_procs.
26 nagios_check_tcp_params:
27
28=== modified file 'templates/input-file-syslog.conf'
29--- templates/input-file-syslog.conf 2014-09-23 12:12:45 +0000
30+++ templates/input-file-syslog.conf 2015-11-04 00:28:08 +0000
31@@ -1,1 +1,1 @@
32-input { file { type => 'syslog' path => ['/var/log/syslog','/var/log/kern.log','/var/log/auth.log','/var/log/dpkg.log'] sincedb_path => '{{BASEPATH}}' } }
33\ No newline at end of file
34+input { file { type => 'syslog' path => ['/var/log/syslog','/var/log/kern.log','/var/log/auth.log','/var/log/dpkg.log'] } }
35
36=== modified file 'templates/input-redis.conf'
37--- templates/input-redis.conf 2014-09-23 12:12:45 +0000
38+++ templates/input-redis.conf 2015-11-04 00:28:08 +0000
39@@ -1,1 +1,1 @@
40-input { redis { host => "127.0.0.1" data_type => "list" type => "redis" tags => ["redis"] key => "logstash" message_format => "json_event" } }
41\ No newline at end of file
42+input { redis { host => "127.0.0.1" data_type => "list" type => "redis" tags => ["redis"] key => "logstash" } }
43
44=== modified file 'templates/output-elasticsearch.conf'
45--- templates/output-elasticsearch.conf 2014-09-23 16:59:13 +0000
46+++ templates/output-elasticsearch.conf 2015-11-04 00:28:08 +0000
47@@ -1,5 +1,5 @@
48 output {
49- elasticsearch_http {
50- host => "{{hosts}}"
51+ elasticsearch {
52+ hosts => "{{hosts}}"
53 }
54 }

Subscribers

People subscribed via source and target branches