Merge lp:~michael.nelson/charms/precise/nrpe/install-nagios-plugins-basic into lp:charms/nrpe

[Michael Nelson]

Install nagios-plugins-basic during install hook.

This may instead be a bug of charmhelpers.contrib.charmsupport.nrpe.NRPE().add_check() - let me know and I'll create a bug there instead for the silent failure.

I was testing a charm that I'm working on, and noticed that the nrpe config was silently failing when using charmhelpers.contrib.charmsupport.nrpe.NRPE().write(), resulting in the following config:

root@michael-local-machine-1:~# cat /etc/nagios/nrpe.d/check_http.cfg
# check http
command[check_http]=

Looking around, the reason is because the check_http plugin is not available, and add_check() only accepts the passed command if it finds it in the normal nagios plugins directories.

For the moment, I'm installing nagios-plugins-basic during the principle charm's install hook, which in retrospect, is probably the right thing to do (and have charmhelpers add_check() fail when the command is not found. But I thought it may also be useful if the nrpe subordinate installed this anyway - let me know.

[Nick Moffitt (nick-moffitt)]

I find it hard to imagine a situation where we would install nagios-nrpe-server but not nagios-plugins-basic.

review: Approve

[Matt Bruzek (mbruzek)]

I reviewed this charm, it deploys and the nagios-nrpe-server package is installed.

$ dpkg -l | grep nrpe
ii nagios-nrpe-server 2.12-5ubuntu1.2 Nagios Remote Plugin Executor Server

Please consider updating the README for this charm on the next update. Thanks!

+1 LGTM

review: Approve

=== modified file 'hooks/install'
--- hooks/install	2012-07-26 23:49:50 +0000
+++ hooks/install	2014-02-13 11:10:52 +0000
@@ -4,7 +4,7 @@
 add-apt-repository -y ppa:charmers/charm-helpers
 apt-get update
 
-apt-get install -y nagios-nrpe-server charm-helper-sh
+apt-get install -y nagios-nrpe-server nagios-plugins-basic charm-helper-sh
 # used in base monitors
 cat > /etc/nagios/nrpe.d/base-monitors.cfg <<EOF
 command[check_root_disk]=/usr/lib/nagios/plugins/check_disk -w 20 -c 10 -p /