Compiz

Merge lp:~michael-thayer/compiz/lp-1353675-compiz-0.9.11 into lp:compiz/0.9.11

  1. lp-1353675-compiz-0.9.11
  2. Merge into 0.9.11
Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 3867
Merged at revision: 3870
Proposed branch: lp:~michael-thayer/compiz/lp-1353675-compiz-0.9.11
Merge into: lp:compiz/0.9.11
Diff against target: 16 lines (+4/-2)
1 file modified
src/window.cpp (+4/-2)
To merge this branch: bzr merge lp:~michael-thayer/compiz/lp-1353675-compiz-0.9.11
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Review via email: mp+235158@code.launchpad.net

Commit message

use correct screen extents for multi-monitor positioning of fullscreen windows (lp: #1353675)

Description of the change

Fix for LP #1353675: _NET_WM_FULLSCREEN_MONITORS not handled correctly. An (x, y, w, h) API was called with (x1, y1, x2, y2).

Test case: a dual-screen VirtualBox guest on a dual-screen Ubuntu 14.10 host is not displayed correctly in full-screen without this fix.

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/window.cpp'
2--- src/window.cpp 2014-06-17 20:02:23 +0000
3+++ src/window.cpp 2014-09-18 15:37:02 +0000
4@@ -467,8 +467,10 @@
5 {
6 CompRect fsRect (screen->outputDevs ()[monitors->left].x1 (),
7 screen->outputDevs ()[monitors->top].y1 (),
8- screen->outputDevs ()[monitors->right].x2 (),
9- screen->outputDevs ()[monitors->bottom].y2 ());
10+ screen->outputDevs ()[monitors->right].x2 () -
11+ screen->outputDevs ()[monitors->left].x1 (),
12+ screen->outputDevs ()[monitors->bottom].y2 () -
13+ screen->outputDevs ()[monitors->top].y1 ());
14
15 if (fsRect.x1 () < fsRect.x2 () && fsRect.y1 () < fsRect.y2 ())
16 {

Subscribers

People subscribed via source and target branches