Code review comment for lp:~michael-sheldon/webbrowser-app/implement-download-folder

Revision history for this message
Olivier Tilloy (osomon) wrote :

src/app/webbrowser/ContentPickerDialog.qml breaks encapsulation by doing this:

    onCancelPressed: webview.focus = true

Instead, you should do:

    onCancelPressed: WebView.view.focus = true

(the 'WebView.view' attached property points to the parent webview).

By the way, is this still needed, and if so shouldn’t it be WebView.view.forceActiveFocus() ?

review: Needs Fixing

« Back to merge proposal