Code review comment for lp:~michael-sheldon/webbrowser-app/implement-download-folder

Revision history for this message
Olivier Tilloy (osomon) wrote :

The ContentDownloadDialog.qml implementations don’t need to be an instance of Component, their top-level element can be PopupBase.

The decoupling done at revision 1209 looks good. I suppose you’re aware of it, but just as a reminder to myself: src/app/ContentPickerDialog.qml still breaks encapsulation by referring to 'webapp' and 'browser'.

« Back to merge proposal