Merge lp:~michael-sheldon/webbrowser-app/fix-1577834 into lp:webbrowser-app

[Michael Sheldon]

Add user-agent override to display the new twitter mobile interface.

Add user-agent override to display the new twitter mobile interface.

[system-apps-ci-bot (system-apps-ci-bot)]

FAILED: Continuous integration, rev:1449
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/477/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build/479
    FAILURE: https://jenkins.canonical.com/system-apps/job/test-0-autopkgtest/label=phone-armhf,release=vivid+overlay,testname=default/35/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/479
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/478
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial/478
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/485
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/485/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial/485
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial/485/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/485
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/485/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial/485
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial/485/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/485
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/485/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial/485
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial/485/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/477/rebuild

review: Needs Fixing (continuous-integration)

[Andrew Hayzen (ahayzen)]

LGTM, twitter is now usable again on mobile \o/

However this branch conflicts with staging, so I've created a new MP [0] which is against staging.

0 - https://code.launchpad.net/~ahayzen/webbrowser-app/fix-1577834-twitter-ua-overrides/+merge/308486

[Olivier Tilloy (osomon)]

Superseded by https://code.launchpad.net/~ahayzen/webbrowser-app/fix-1577834-twitter-ua-overrides/+merge/308486.

review: Disapprove

Unmerged revisions

1449. By Michael Sheldon on 2016-05-03

Add user-agent override to display the new twitter mobile interface

=== modified file 'src/Ubuntu/Web/ua-overrides-desktop.js'
--- src/Ubuntu/Web/ua-overrides-desktop.js	2016-04-05 09:02:55 +0000
+++ src/Ubuntu/Web/ua-overrides-desktop.js	2016-05-03 16:07:28 +0000
@@ -24,6 +24,7 @@
       ["^https?:\/\/(www\.)?youtube\.com\/", "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 Chrome/35.0.1870.2 Safari/537.36"], // http://pad.lv/1412880
       ["^https?:\/\/(www\.)?google\..+\/maps", "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 Chrome/35.0.1870.2 Safari/537.36"], // http://pad.lv/1503506, http://pad.lv/1551649
       ["^https?:\/\/mail\.google\.com\/", "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 Chrome/47.0.2526.106 Safari/537.36"], // http://pad.lv/1452616
+      ["^https?:\/\/mobile\.twitter\.com\/", "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 Chrome/49.0.2623.87 Safari/537.36"], // http://pad.lv/1577834
 
       // Google hangouts (https://launchpad.net/bugs/1565055)
       ["^https?:\/\/hangouts\.google\.com\/", "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 Chrome/49.0.2623.87 Safari/537.36"],

=== modified file 'src/Ubuntu/Web/ua-overrides-mobile.js'
--- src/Ubuntu/Web/ua-overrides-mobile.js	2016-04-25 19:28:03 +0000
+++ src/Ubuntu/Web/ua-overrides-mobile.js	2016-05-03 16:07:28 +0000
@@ -25,6 +25,8 @@
     ["^https?:\/\/(\w+\.)*hsbc\.com\.br\/", "Mozilla/5.0 (Linux; Ubuntu 14.04 like Android 4.4;) AppleWebKit/537.36 Chrome/35.0.1870.2 Mobile Safari/537.36"], // http://pad.lv/1380657
     ["^http:\/\/(\w+\.)*espn\.(go\.)?com\/", "Mozilla/5.0 (Linux; Ubuntu 14.04 like Android 4.4;) AppleWebKit/537.36 Chrome/35.0.1870.2 Mobile Safari/537.36"], // http://pad.lv/1316259
     ["^https?:\/\/(www|m)\.facebook\.com\/", "Mozilla/5.0 (Linux; Ubuntu 14.04; Android 5.0; Nexus 5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/38.0.2125.102 Mobile Safari/537.36"], // http://pad.lv/1538056, http://pad.lv/1457661
+    ["^https?:\/\/mobile\.twitter\.com\/", "Mozilla/5.0 (Linux; Ubuntu 14.04;) AppleWebKit/537.36 Chrome/49.0.2623.87 Mobile Safari/537.36"], // http://pad.lv/1577834
+
     // Google hangouts (https://launchpad.net/bugs/1565055)
     ["^https?:\/\/hangouts\.google\.com\/", "Mozilla/5.0 (Linux; Ubuntu 14.04 like Android 4.4;) AppleWebKit/537.36 Chrome/49.0.2623.87 Mobile Safari/537.36"],
     ["^https?:\/\/talkgadget\.google\.com\/hangouts\/", "Mozilla/5.0 (Linux; Ubuntu 14.04 like Android 4.4;) AppleWebKit/537.36 Chrome/49.0.2623.87 Mobile Safari/537.36"],