Merge lp:~michael-sheldon/webbrowser-app/fix-1413964 into lp:webbrowser-app

Proposed by Michael Sheldon
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 872
Merged at revision: 873
Proposed branch: lp:~michael-sheldon/webbrowser-app/fix-1413964
Merge into: lp:webbrowser-app
Diff against target: 27 lines (+4/-2)
2 files modified
src/Ubuntu/Components/Extras/Browser/selection01.js (+2/-1)
src/Ubuntu/Web/selection02.js (+2/-1)
To merge this branch: bzr merge lp:~michael-sheldon/webbrowser-app/fix-1413964
Reviewer Review Type Date Requested Status
Olivier Tilloy Approve
Review via email: mp+247422@code.launchpad.net

Commit message

Keep data URIs in their original form when retrieving image URLs

Description of the change

Keep data URIs in their original form when retrieving image URLs

To post a comment you must log in.
Revision history for this message
Olivier Tilloy (osomon) wrote :

Looks good, and I verified that it fixes bug #1413964.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Ubuntu/Components/Extras/Browser/selection01.js'
2--- src/Ubuntu/Components/Extras/Browser/selection01.js 2014-04-23 12:30:01 +0000
3+++ src/Ubuntu/Components/Extras/Browser/selection01.js 2015-01-23 13:29:33 +0000
4@@ -31,7 +31,8 @@
5 function getImgFullUri(uri) {
6 if ((uri.slice(0, 7) === 'http://') ||
7 (uri.slice(0, 8) === 'https://') ||
8- (uri.slice(0, 7) === 'file://')) {
9+ (uri.slice(0, 7) === 'file://') ||
10+ (uri.slice(0, 5) === 'data:')) {
11 return uri;
12 } else if (uri.slice(0, 1) === '/') {
13 var docuri = document.documentURI;
14
15=== modified file 'src/Ubuntu/Web/selection02.js'
16--- src/Ubuntu/Web/selection02.js 2014-06-19 07:40:21 +0000
17+++ src/Ubuntu/Web/selection02.js 2015-01-23 13:29:33 +0000
18@@ -25,7 +25,8 @@
19 function getImgFullUri(uri) {
20 if ((uri.slice(0, 7) === 'http://') ||
21 (uri.slice(0, 8) === 'https://') ||
22- (uri.slice(0, 7) === 'file://')) {
23+ (uri.slice(0, 7) === 'file://') ||
24+ (uri.slice(0, 5) === 'data:')) {
25 return uri;
26 } else if (uri.slice(0, 1) === '/') {
27 var docuri = document.documentURI;

Subscribers

People subscribed via source and target branches

to status/vote changes: