Merge lp:~michael-sheldon/webapps-demo/twitter-location into lp:webapps-demo

Proposed by Michael Sheldon
Status: Needs review
Proposed branch: lp:~michael-sheldon/webapps-demo/twitter-location
Merge into: lp:webapps-demo
Diff against target: 25 lines (+3/-2)
2 files modified
webapp-twitter/manifest.json (+1/-1)
webapp-twitter/webapp-twitter.json (+2/-1)
To merge this branch: bzr merge lp:~michael-sheldon/webapps-demo/twitter-location
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
David Barth Pending
Ubuntu Phablet Team Pending
Review via email: mp+206973@code.launchpad.net

Commit message

Add permission for location detection

Description of the change

This adds the "location" policy group to the twitter app and bumps the version number, fixing bug #1281631 (twitter app crashes when accessing location).

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:35
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~michael-sheldon/webapps-demo/twitter-location/+merge/206973/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/webapps-demo-ci/38/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webapps-demo-saucy-armhf-ci/21
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webapps-demo-saucy-i386-ci/21

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webapps-demo-ci/38/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Are there any related MPs required for this MP to build/function as expected? Please list.

 * No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

 * Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

 * Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?

 * No test plan, performed manual tests of basic functionality.

If you changed the UI, was the change specified/approved by design?

 * No change

If you changed the packaging (debian), did you subscribe a core-dev to this MP?

 * No change

Unmerged revisions

35. By Michael Sheldon

Add location policy group to twitter app (fixes crash when tweeting with location detection allowed)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'webapp-twitter/manifest.json'
2--- webapp-twitter/manifest.json 2013-10-15 17:17:21 +0000
3+++ webapp-twitter/manifest.json 2014-02-18 15:50:28 +0000
4@@ -10,6 +10,6 @@
5 "maintainer": "Webapps Team <webapps@lists.launchpad.net>",
6 "name": "com.ubuntu.developer.webapps.webapp-twitter",
7 "title": "webapp-twitter",
8- "version": "1.0.5"
9+ "version": "1.0.6"
10 }
11
12
13=== modified file 'webapp-twitter/webapp-twitter.json'
14--- webapp-twitter/webapp-twitter.json 2013-09-20 15:59:48 +0000
15+++ webapp-twitter/webapp-twitter.json 2014-02-18 15:50:28 +0000
16@@ -3,7 +3,8 @@
17 "policy_groups": [
18 "networking",
19 "audio",
20- "video"
21+ "video",
22+ "location"
23 ],
24 "policy_version": 1.0
25 }

Subscribers

People subscribed via source and target branches