Merge lp:~michael-sheldon/ubuntu-ui-toolkit/remove-keyboard-margin-animation into lp:ubuntu-ui-toolkit/staging

Proposed by Michael Sheldon
Status: Merged
Approved by: Tim Peeters
Approved revision: 1279
Merged at revision: 1279
Proposed branch: lp:~michael-sheldon/ubuntu-ui-toolkit/remove-keyboard-margin-animation
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 17 lines (+0/-7)
1 file modified
modules/Ubuntu/Components/MainView.qml (+0/-7)
To merge this branch: bzr merge lp:~michael-sheldon/ubuntu-ui-toolkit/remove-keyboard-margin-animation
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Tim Peeters Approve
Review via email: mp+237275@code.launchpad.net

Commit message

Removes the keyboard anchor animation as this is now implemented in the keyboard.

Description of the change

Removes the keyboard anchor animation, as the reporting of the keyboard height during showing/hiding animations is now fixed in the ubuntu-keyboard and maliit-framework.

To post a comment you must log in.
Revision history for this message
Tim Peeters (tpeeters) wrote :

The code changes make sense.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'modules/Ubuntu/Components/MainView.qml'
2--- modules/Ubuntu/Components/MainView.qml 2014-09-07 16:42:47 +0000
3+++ modules/Ubuntu/Components/MainView.qml 2014-10-06 13:57:30 +0000
4@@ -245,13 +245,6 @@
5
6 automaticOrientation: false
7 anchorToKeyboard: mainView.anchorToKeyboard
8- anchors {
9- //this is an attempt to keep the keyboard animation in sync with the content resize
10- //but this does not work very well because the keyboard animation has different steps
11- Behavior on bottomMargin {
12- NumberAnimation { easing.type: Easing.InOutQuad }
13- }
14- }
15
16 // clip the contents so that it does not overlap the header
17 Item {

Subscribers

People subscribed via source and target branches