Merge lp:~michael-sheldon/ubuntu-system-settings/custom-keyboard-opacity into lp:ubuntu-system-settings

[Michael Sheldon]

Add keyboard opacity setting to language panel

Add keyboard opacity setting to language panel

[system-apps-ci-bot (system-apps-ci-bot)]

PASSED: Continuous integration, rev:1749
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-system-settings-ci/272/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build/2172
    SUCCESS: https://jenkins.canonical.com/system-apps/job/test-0-autopkgtest/label=phone-armhf,release=vivid+overlay,testname=default/560
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/2175
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2001
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2001/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2001
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2001/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2001
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2001/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2001
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2001/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2001
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2001/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2001
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2001/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/2001
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/2001/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2001
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2001/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2001
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2001/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-system-settings-ci/272/rebuild

review: Approve (continuous-integration)

[Jonas G. Drange (jonas-drange)]

Looks good, however, when I do $ gsettings list-keys com.canonical.keyboard.maliit---opacity does not show up. Is this key being added elsewhere?

review: Needs Information

[Michael Sheldon (michael-sheldon)]

Yep, that's added in this MR: https://code.launchpad.net/~michael-sheldon/ubuntu-keyboard/custom-opacity/+merge/312960

Currently both are built together in silo 2289 for testing: https://bileto.ubuntu.com/#/ticket/2289

[Jonas G. Drange (jonas-drange)]

Very good, thank you Michael.

review: Approve

=== modified file 'plugins/language/PageComponent.qml'
--- plugins/language/PageComponent.qml	2016-11-29 11:12:13 +0000
+++ plugins/language/PageComponent.qml	2016-12-10 01:17:52 +0000
@@ -27,6 +27,7 @@
 import Ubuntu.Components.ListItems 1.3 as ListItem
 import Ubuntu.Settings.Menus 0.1 as Menus
 import Ubuntu.SystemSettings.LanguagePlugin 1.0
+import Ubuntu.Settings.Components 0.1 as USC
 
 ItemPage {
     id: root
@@ -281,6 +282,29 @@
                     onTriggered: settings.keyPressHapticFeedback = checked
                 }
             }
+
+            Menus.SliderMenu {
+                text: i18n.tr("Keyboard opacity")
+
+                id: opacity
+                objectName: "opacity"
+                function formatValue(v) { return v * 100 }
+                minimumValue: 0.5
+                maximumValue: 1
+                value: settings.opacity
+                live: true
+
+                property real serverValue: settings.opacity
+                USC.ServerPropertySynchroniser {
+                    userTarget: opacity
+                    userProperty: "value"
+                    serverTarget: opacity
+                    serverProperty: "serverValue"
+                    maximumWaitBufferInterval: 16
+
+                    onSyncTriggered: settings.opacity = value
+                }
+            }
         }
     }
 }