Merge lp:~michael-sheldon/ubuntu-keyboard/fix-build-against-new-libplatform into lp:ubuntu-keyboard

Proposed by Michael Sheldon
Status: Merged
Approved by: Bill Filler
Approved revision: 391
Merged at revision: 391
Proposed branch: lp:~michael-sheldon/ubuntu-keyboard/fix-build-against-new-libplatform
Merge into: lp:ubuntu-keyboard
Diff against target: 28 lines (+0/-10)
1 file modified
src/plugin/ubuntuapplicationapiwrapper.cpp (+0/-10)
To merge this branch: bzr merge lp:~michael-sheldon/ubuntu-keyboard/fix-build-against-new-libplatform
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+265104@code.launchpad.net

Commit message

Allow the keyboard to build with new version of platform-api

Description of the change

Allow the keyboard to build with new version of platform-api

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Are there any related MPs required for this MP to build/function as expected? Please list.

 * No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

 * Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

 * Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/ubuntu-keyboard) on device or emulator?

 * Yes

If you changed the UI, was the change specified/approved by design?

 * No change

If you changed UI labels, did you update the pot file?

 * No change

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?

 * No change

Note: CI will fail due to autopilot adding a fake keyboard which unity then detects causing it to suppress the OSK.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/plugin/ubuntuapplicationapiwrapper.cpp'
2--- src/plugin/ubuntuapplicationapiwrapper.cpp 2014-04-16 13:12:34 +0000
3+++ src/plugin/ubuntuapplicationapiwrapper.cpp 2015-07-17 10:22:35 +0000
4@@ -19,12 +19,6 @@
5 // FIXME: this is hacky way of deciding if running on Touch platform or not
6 #include <QtCore/qconfig.h>
7
8-#ifdef QT_OPENGL_ES_2
9-#include <ubuntu/ui/ubuntu_ui_session_service.h>
10-#include <ubuntu/application/ui/window_properties.h>
11- #define HAVE_UBUNTU_PLATFORM_API
12-#endif
13-
14 #include <QByteArray>
15 #include <QDir>
16 #include <QFile>
17@@ -95,11 +89,7 @@
18
19 int UbuntuApplicationApiWrapper::oskWindowRole() const
20 {
21-#ifdef HAVE_UBUNTU_PLATFORM_API
22- return static_cast<int>(U_ON_SCREEN_KEYBOARD_ROLE);
23-#else
24 return 7;
25-#endif
26 }
27
28 void UbuntuApplicationApiWrapper::sendInfoToClientConnection()

Subscribers

People subscribed via source and target branches