Merge lp:~michael-sheldon/ubuntu-keyboard/fix-1526795 into lp:ubuntu-keyboard

Proposed by Michael Sheldon
Status: Merged
Approved by: Bill Filler
Approved revision: 432
Merged at revision: 432
Proposed branch: lp:~michael-sheldon/ubuntu-keyboard/fix-1526795
Merge into: lp:ubuntu-keyboard
Diff against target: 20 lines (+2/-1)
1 file modified
qml/WordRibbon.qml (+2/-1)
To merge this branch: bzr merge lp:~michael-sheldon/ubuntu-keyboard/fix-1526795
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+281082@code.launchpad.net

Commit message

Make user input bold if there aren't any suggestions and expose bold property to autopilot

Description of the change

Make user input bold if there aren't any suggestions and expose bold property to autopilot

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Are there any related MPs required for this MP to build/function as expected? Please list.

 * No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

 * Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

 * Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/ubuntu-keyboard) on device or emulator?

 * Yes

If you changed the UI, was the change specified/approved by design?

 * No change

If you changed UI labels, did you update the pot file?

 * No change

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?

 * No change

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/WordRibbon.qml'
2--- qml/WordRibbon.qml 2014-08-18 12:00:08 +0000
3+++ qml/WordRibbon.qml 2015-12-21 11:48:29 +0000
4@@ -48,6 +48,7 @@
5 height: wordRibbonCanvas.height
6 anchors.margins: 0
7 property alias word_text: wordItem // For testing in Autopilot
8+ property alias textBold: wordItem.font.bold // Exposed for autopilot
9
10 Item {
11 anchors.fill: parent
12@@ -63,7 +64,7 @@
13 font.pixelSize: units.gu(1.9)
14 font.family: "Ubuntu Medium"
15 color: "#999999"
16- font.bold: isPrimaryCandidate
17+ font.bold: isPrimaryCandidate || listView.count == 1
18 text: word;
19 anchors.centerIn: parent
20 }

Subscribers

People subscribed via source and target branches