Merge lp:~michael-sheldon/ubuntu-keyboard/fix-1398503 into lp:ubuntu-keyboard

[Michael Sheldon]

Disables automatic insertion of space characters after punctuation except when punctuation has been added by double space.

Disables automatic insertion of space characters after punctuation except when punctuation has been added by double space.

[Michael Sheldon (michael-sheldon)]

Are there any related MPs required for this MP to build/function as expected? Please list.

 * No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

 * Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

 * Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/ubuntu-keyboard) on device or emulator?

 * Yes

If you changed the UI, was the change specified/approved by design?

 * No change

If you changed UI labels, did you update the pot file?

 * No change

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?

 * No change

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:257
http://jenkins.qa.ubuntu.com/job/ubuntu-keyboard-ci/518/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-keyboard-vivid-amd64-ci/19
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-keyboard-vivid-armhf-ci/19
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-keyboard-vivid-armhf-ci/19/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-keyboard-vivid-i386-ci/19

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-keyboard-ci/518/rebuild

review: Approve (continuous-integration)

[lp:~michael-sheldon/ubuntu-keyboard/fix-1398503]

258. By Michael Sheldon on 2014-12-09

Only enter autocaps if the user has entered a space after punctuation

259. By Michael Sheldon on 2014-12-09

Update autopilot tests to account for new autocaps behaviour

[Bill Filler (bfiller)]

approved

review: Approve

=== modified file 'plugins/westernsupport/westernlanguagefeatures.cpp'
--- plugins/westernsupport/westernlanguagefeatures.cpp	2014-10-21 18:54:25 +0000
+++ plugins/westernsupport/westernlanguagefeatures.cpp	2014-12-09 15:28:00 +0000
@@ -60,7 +60,7 @@
         return false;
     }
 
-    if (sentenceBreak.contains(preedit.right(1))) {
+    if (sentenceBreak.contains(preedit.mid(preedit.length() - 2, 1)) && preedit.right(1) == " ") {
         return true;
     }
 

=== modified file 'src/view/abstracttexteditor.cpp'
--- src/view/abstracttexteditor.cpp	2014-11-26 15:02:05 +0000
+++ src/view/abstracttexteditor.cpp	2014-12-09 15:28:00 +0000
@@ -465,10 +465,6 @@
                 // this means we should commit the candidate, add the separator and whitespace
                 d->text->setPreedit(d->text->primaryCandidate());
                 d->text->appendToPreedit(text);
-                if (d->keyboardState == "CHARACTERS" && !email_detected) {
-                    d->appendix_for_previous_preedit = d->word_engine->languageFeature()->appendixForReplacedPreedit(d->text->preedit());
-                    d->text->appendToPreedit(d->appendix_for_previous_preedit);
-                }
                 commitPreedit();
                 if (!email_detected) {
                     auto_caps_activated = d->word_engine->languageFeature()->activateAutoCaps(d->text->surroundingLeft() + d->text->preedit() + text);
@@ -484,9 +480,6 @@
                 d->text->appendToPreedit(text);
                 if (!email_detected) {
                     auto_caps_activated = d->word_engine->languageFeature()->activateAutoCaps(d->text->surroundingLeft() + d->text->preedit());
-                    if(isSeparator && d->keyboardState == "CHARACTERS") {
-                        d->text->appendToPreedit(d->word_engine->languageFeature()->appendixForReplacedPreedit(d->text->preedit()));
-                    }
                 }
                 commitPreedit();
                 alreadyAppended = true;

=== modified file 'tests/autopilot/ubuntu_keyboard/tests/test_keyboard.py'
--- tests/autopilot/ubuntu_keyboard/tests/test_keyboard.py	2014-12-02 19:24:45 +0000
+++ tests/autopilot/ubuntu_keyboard/tests/test_keyboard.py	2014-12-09 15:28:00 +0000
@@ -316,8 +316,8 @@
         self.assertThat(text_area.text, Eventually(Equals('abcA')))
 
     def test_shift_state_entered_after_fullstop(self):
-        """After typing a fullstop the keyboard state must automatically
-        enter the shifted state.
+        """After typing a fullstop followed by a space the keyboard state must
+        automatically enter the shifted state.
 
         """
         text_area = self.launch_test_input_area(input_hints=['Qt.ImhNoPredictiveText'])
@@ -325,11 +325,11 @@
         keyboard = Keyboard()
         self.addCleanup(keyboard.dismiss)
 
-        keyboard.type("abc.")
+        keyboard.type("abc. ")
 
         self.assertThat(
             text_area.text,
-            Eventually(Equals("abc."))
+            Eventually(Equals("abc. "))
         )
 
         self.assertThat(
@@ -346,7 +346,7 @@
         keyboard = Keyboard()
         self.addCleanup(keyboard.dismiss)
 
-        keyboard.type("Hello my friend.\b")
+        keyboard.type("Hello my friend. \b\b")
 
         self.assertThat(
             text_area.text,

=== modified file 'tests/unittests/ut_editor/ut_editor.cpp'
--- tests/unittests/ut_editor/ut_editor.cpp	2014-07-22 14:02:39 +0000
+++ tests/unittests/ut_editor/ut_editor.cpp	2014-12-09 15:28:00 +0000
@@ -114,9 +114,9 @@
         // FIXME: In the current testing infra, we cannot really test this properly, as we are using the 'backspace' character
         //  a lot during auto-correction, which is currently not handled too well here.
         QTest::newRow("auto-correct enabled, commit with space, check separators")
-                << true << "Hel ,Wor ." << "Hello , World . ";
+                << true << "Hel , Wor ." << "Hello , World .";
         QTest::newRow("auto-correct enabled, commit with separators, check separators")
-                << true << "Hel.Wor." << "Hello. World. ";
+                << true << "Hel. Wor." << "Hello. World.";
         QTest::newRow("auto-correct enabled, check if two spaces are full-stop")
                 << true << "Hel  " << "Hello . ";      
         //QTest::newRow("auto-correct enabled, check removal of unnecessary whitespaces")
@@ -183,25 +183,16 @@
         QTest::newRow("auto-correct disabled, multiple sentences with mixed punctation")
                 << false << "This is a \"first sentence\". And a second, one! "
                 << "This is a \"first sentence\". And a second, one! " << 2;
-        QTest::newRow("auto-correct enabled, multiple sentences with mixed punctation")
-                << true << "This is a \"first sentence\".And a second,one!"
-                << "This is a \"first sentence\". And a second, one! " << 2;
         QTest::newRow("auto-correct disabled, multiple sentences with dots")
                 << false << "First sentence. Second one. And Third. "
                 << "First sentence. Second one. And Third. " << 3;
-        QTest::newRow("auto-correct enabled, multiple sentences with dots")
-                << true << "First sentence.Second one.And Third."
-                << "First sentence. Second one. And Third. " << 3;
 
         // Tests for the auto-correct and autocaps separator functionality
         // FIXME: In the current testing infra, we cannot really test this properly, as we are using the 'backspace' character
         //  a lot during auto-correction, which is currently not handled too well here.
         QTest::newRow("auto-correct enabled, autocaps after separator auto-correction")
-                << true << "Hello Wor .This should be autocapsed "
-                << "Hello World . This should be autocapsed " << 1;
-        QTest::newRow("auto-correct enabled, autocaps after separator auto-correction #2")
-                << true << "Hello Wor .This should be autocapsed "
-                << "Hello World . This should be autocapsed " << 1;
+                << true << "Hello Wor . This should be autocapsed "
+                << "Hello World . This should be autocapsed " << 2;
     }
 
     Q_SLOT void testAutoCaps()