ubuntu-keyboard

Merge lp:~michael-sheldon/ubuntu-keyboard/fix-1390395 into lp:ubuntu-keyboard

  1. fix-1390395
  2. Merge into trunk
Proposed by Michael Sheldon
Status: Merged
Approved by: Łukasz Zemczak
Approved revision: 242
Merged at revision: 242
Proposed branch: lp:~michael-sheldon/ubuntu-keyboard/fix-1390395
Merge into: lp:ubuntu-keyboard
Diff against target: 11 lines (+1/-0)
1 file modified
src/lib/logic/wordengine.cpp (+1/-0)
To merge this branch: bzr merge lp:~michael-sheldon/ubuntu-keyboard/fix-1390395
Reviewer Review Type Date Requested Status
Łukasz Zemczak Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+241063@code.launchpad.net

Commit message

Fix uninitialised pointer.

Description of the change

Fix uninitialised pointer.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:242
http://jenkins.qa.ubuntu.com/job/ubuntu-keyboard-ci/500/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-keyboard-vivid-amd64-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-keyboard-vivid-armhf-ci/1
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-keyboard-vivid-armhf-ci/1/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-keyboard-vivid-i386-ci/1

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-keyboard-ci/500/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Are there any related MPs required for this MP to build/function as expected? Please list.

 * No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

 * Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

 * Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/ubuntu-keyboard) on device or emulator?

 * Yes

If you changed the UI, was the change specified/approved by design?

 * No change

If you changed UI labels, did you update the pot file?

 * No change

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?

 * No change

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

This works. And looks perfect! +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/lib/logic/wordengine.cpp'
2--- src/lib/logic/wordengine.cpp 2014-10-29 13:57:51 +0000
3+++ src/lib/logic/wordengine.cpp 2014-11-07 11:39:50 +0000
4@@ -114,6 +114,7 @@
5 , calculated_primary_candidate(false)
6 , clear_candidates_on_incoming(false)
7 , languagePlugin(0)
8+ , currentText(0)
9 {
10 loadPlugin(DEFAULT_PLUGIN);
11 candidates = new WordCandidateList();

Subscribers

People subscribed via source and target branches