Merge lp:~michael-sheldon/ubuntu-keyboard/fix-1385518-rtm into lp:ubuntu-keyboard/rtm-14.09

[Michael Sheldon]

Fire release event when backspace key is swiped out of to stop the backspace getting stuck.

Fire release event when backspace key is swiped out of to stop the backspace getting stuck.

[Michael Sheldon (michael-sheldon)]

Are there any related MPs required for this MP to build/function as expected? Please list.

 * No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

 * In sync with rtm-14.09 branch

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

 * Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/ubuntu-keyboard) on device or emulator?

 * Yes, except for last test in word prediction section as this isn't implemented in the 14.09 branch.

If you changed the UI, was the change specified/approved by design?

 * No change

If you changed UI labels, did you update the pot file?

 * No change

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?

 * No change

[Bill Filler (bfiller)]

approved

review: Approve

=== modified file 'qml/keys/CharKey.qml'
--- qml/keys/CharKey.qml	2014-10-07 15:44:46 +0000
+++ qml/keys/CharKey.qml	2014-12-04 01:11:12 +0000
@@ -223,6 +223,12 @@
                     panel.state = "CHARACTERS";
                 }
                 event_handler.onKeyReleased(keyToSend, action);
+            } else if (action == "backspace") {
+                // Send release from backspace if we're swiped out since
+                // backspace activates on press and deactivates on release
+                // to allow for repeated backspaces, unlike normal keys
+                // which activate on release.
+                event_handler.onKeyReleased(valueToSubmit, action);
             }
         }