Merge lp:~michael-sheldon/ubuntu-keyboard/fix-1372548 into lp:ubuntu-keyboard

Proposed by Michael Sheldon
Status: Merged
Approved by: Bill Filler
Approved revision: 264
Merged at revision: 263
Proposed branch: lp:~michael-sheldon/ubuntu-keyboard/fix-1372548
Merge into: lp:ubuntu-keyboard
Diff against target: 12 lines (+1/-1)
1 file modified
qml/languages/Keyboard_telephone.qml (+1/-1)
To merge this branch: bzr merge lp:~michael-sheldon/ubuntu-keyboard/fix-1372548
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+244438@code.launchpad.net

Commit message

Change extended keys on phone layout to '*#'

Description of the change

Change extended keys on phone layout to '*#'

To post a comment you must log in.
Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Are there any related MPs required for this MP to build/function as expected? Please list.

 * No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

 * Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

 * Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/ubuntu-keyboard) on device or emulator?

 * Yes

If you changed the UI, was the change specified/approved by design?

 * No change

If you changed UI labels, did you update the pot file?

 * No change

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?

 * No change

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
264. By Michael Sheldon

Remove , and ; from the telephone layout's extended keys

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/languages/Keyboard_telephone.qml'
2--- qml/languages/Keyboard_telephone.qml 2014-05-28 11:14:15 +0000
3+++ qml/languages/Keyboard_telephone.qml 2014-12-12 17:28:37 +0000
4@@ -65,7 +65,7 @@
5 anchors.margins: 50;
6 spacing: 0
7
8- CharKey { label: "+"; annotation: "+*#"; extended: ["*", "#", "(", ")"]; noMagnifier: true; }
9+ CharKey { label: "+"; annotation: "*#"; extended: ["*", "#"]; noMagnifier: true; }
10 CharKey { label: "0"; noMagnifier: true; }
11 BackspaceKey { padding: 0; }
12 }

Subscribers

People subscribed via source and target branches