Merge lp:~michael-sheldon/ubuntu-keyboard/fix-1370071 into lp:ubuntu-keyboard

Proposed by Michael Sheldon
Status: Merged
Merged at revision: 239
Proposed branch: lp:~michael-sheldon/ubuntu-keyboard/fix-1370071
Merge into: lp:ubuntu-keyboard
Diff against target: 20 lines (+2/-1)
1 file modified
src/plugin/inputmethod.cpp (+2/-1)
To merge this branch: bzr merge lp:~michael-sheldon/ubuntu-keyboard/fix-1370071
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+240611@code.launchpad.net

Commit message

Fix ImhNoAutoUppercase hint behaviour when switching between apps with autocaps and without.

Description of the change

Fix ImhNoAutoUppercase hint behaviour when switching between apps with autocaps and without.

To post a comment you must log in.
Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Are there any related MPs required for this MP to build/function as expected? Please list.

 * No, although for testing purposes https://code.launchpad.net/~michael-sheldon/ubuntu-terminal-app/disable-autocaps/+merge/240582 is useful

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

 * Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

 * Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/ubuntu-keyboard) on device or emulator?

 * Yes

If you changed the UI, was the change specified/approved by design?

 * No change

If you changed UI labels, did you update the pot file?

 * No change

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?

 * No change

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/plugin/inputmethod.cpp'
2--- src/plugin/inputmethod.cpp 2014-10-07 15:44:46 +0000
3+++ src/plugin/inputmethod.cpp 2014-11-04 17:01:37 +0000
4@@ -362,6 +362,8 @@
5 updateWordEngine();
6 }
7
8+ updateAutoCaps();
9+
10 QString text;
11 int position;
12 bool ok = d->host->surroundingText(text, position);
13@@ -369,7 +371,6 @@
14 d->editor.text()->setSurrounding(text);
15 d->editor.text()->setSurroundingOffset(position);
16
17- updateAutoCaps();
18 checkAutocaps();
19 d->previous_position = position;
20 }

Subscribers

People subscribed via source and target branches