Merge lp:~michael-sheldon/ubuntu-keyboard/custom-plugin-paths into lp:ubuntu-keyboard
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Bill Filler on 2015-04-22 | ||||
| Approved revision: | 354 | ||||
| Merged at revision: | 356 | ||||
| Proposed branch: | lp:~michael-sheldon/ubuntu-keyboard/custom-plugin-paths | ||||
| Merge into: | lp:ubuntu-keyboard | ||||
| Diff against target: |
2548 lines (+460/-390) 140 files modified
data/schemas/com.canonical.keyboard.maliit.gschema.xml (+5/-0) debian/control (+1/-0) plugins/ar/qml/Keyboard_ar.qml (+1/-2) plugins/ar/qml/Keyboard_ar_email.qml (+1/-2) plugins/ar/qml/Keyboard_ar_url.qml (+1/-2) plugins/ar/qml/Keyboard_ar_url_search.qml (+1/-2) plugins/ar/src/src.pro (+1/-1) plugins/az/qml/Keyboard_az.qml (+1/-2) plugins/az/qml/Keyboard_az_email.qml (+1/-2) plugins/az/qml/Keyboard_az_url.qml (+1/-2) plugins/az/qml/Keyboard_az_url_search.qml (+1/-2) plugins/az/src/src.pro (+1/-1) plugins/bs/qml/Keyboard_bs.qml (+1/-2) plugins/bs/qml/Keyboard_bs_email.qml (+1/-2) plugins/bs/qml/Keyboard_bs_url.qml (+1/-2) plugins/bs/qml/Keyboard_bs_url_search.qml (+1/-2) plugins/bs/src/src.pro (+1/-1) plugins/ca/qml/Keyboard_ca.qml (+1/-2) plugins/ca/qml/Keyboard_ca_email.qml (+1/-2) plugins/ca/qml/Keyboard_ca_url.qml (+1/-2) plugins/ca/qml/Keyboard_ca_url_search.qml (+1/-2) plugins/ca/src/src.pro (+1/-1) plugins/cs/qml/Keyboard_cs.qml (+1/-2) plugins/cs/qml/Keyboard_cs_email.qml (+1/-2) plugins/cs/qml/Keyboard_cs_url.qml (+1/-2) plugins/cs/qml/Keyboard_cs_url_search.qml (+1/-2) plugins/cs/src/src.pro (+1/-1) plugins/da/qml/Keyboard_da.qml (+1/-2) plugins/da/qml/Keyboard_da_email.qml (+1/-2) plugins/da/qml/Keyboard_da_url.qml (+1/-2) plugins/da/qml/Keyboard_da_url_search.qml (+1/-2) plugins/da/src/src.pro (+1/-1) plugins/de/qml/Keyboard_de.qml (+1/-2) plugins/de/qml/Keyboard_de_email.qml (+1/-2) plugins/de/qml/Keyboard_de_url.qml (+1/-2) plugins/de/qml/Keyboard_de_url_search.qml (+1/-2) plugins/de/src/src.pro (+1/-1) plugins/emoji/qml/Keyboard_emoji.qml (+1/-2) plugins/en/qml/Keyboard_en.qml (+1/-2) plugins/en/qml/Keyboard_en_email.qml (+1/-2) plugins/en/qml/Keyboard_en_url.qml (+1/-2) plugins/en/qml/Keyboard_en_url_search.qml (+1/-2) plugins/en/src/src.pro (+1/-1) plugins/es/qml/Keyboard_es.qml (+1/-2) plugins/es/qml/Keyboard_es_email.qml (+1/-2) plugins/es/qml/Keyboard_es_url.qml (+1/-2) plugins/es/qml/Keyboard_es_url_search.qml (+1/-2) plugins/es/src/src.pro (+1/-1) plugins/fi/qml/Keyboard_fi.qml (+1/-2) plugins/fi/qml/Keyboard_fi_email.qml (+1/-2) plugins/fi/qml/Keyboard_fi_url.qml (+1/-2) plugins/fi/qml/Keyboard_fi_url_search.qml (+1/-2) plugins/fi/src/src.pro (+1/-1) plugins/fr/qml/Keyboard_fr.qml (+1/-2) plugins/fr/qml/Keyboard_fr_email.qml (+1/-2) plugins/fr/qml/Keyboard_fr_url.qml (+1/-2) plugins/fr/qml/Keyboard_fr_url_search.qml (+1/-2) plugins/fr/src/src.pro (+1/-1) plugins/he/qml/Keyboard_he.qml (+1/-2) plugins/he/qml/Keyboard_he_email.qml (+1/-2) plugins/he/qml/Keyboard_he_url.qml (+1/-2) plugins/he/qml/Keyboard_he_url_search.qml (+1/-2) plugins/he/src/src.pro (+1/-1) plugins/hr/qml/Keyboard_hr.qml (+1/-2) plugins/hr/qml/Keyboard_hr_email.qml (+1/-2) plugins/hr/qml/Keyboard_hr_url.qml (+1/-2) plugins/hr/qml/Keyboard_hr_url_search.qml (+1/-2) plugins/hr/src/src.pro (+1/-1) plugins/hu/qml/Keyboard_hu.qml (+1/-2) plugins/hu/qml/Keyboard_hu_email.qml (+1/-2) plugins/hu/qml/Keyboard_hu_url.qml (+1/-2) plugins/hu/qml/Keyboard_hu_url_search.qml (+1/-2) plugins/hu/src/src.pro (+1/-1) plugins/it/qml/Keyboard_it.qml (+1/-2) plugins/it/qml/Keyboard_it_email.qml (+1/-2) plugins/it/qml/Keyboard_it_url.qml (+1/-2) plugins/it/qml/Keyboard_it_url_search.qml (+1/-2) plugins/it/src/src.pro (+1/-1) plugins/nl/qml/Keyboard_nl.qml (+1/-2) plugins/nl/qml/Keyboard_nl_email.qml (+1/-2) plugins/nl/qml/Keyboard_nl_url.qml (+1/-2) plugins/nl/qml/Keyboard_nl_url_search.qml (+1/-2) plugins/nl/src/src.pro (+1/-1) plugins/pinyin/qml/Keyboard_zh.qml (+1/-2) plugins/pinyin/qml/Keyboard_zh_email.qml (+1/-2) plugins/pinyin/qml/Keyboard_zh_url.qml (+1/-2) plugins/pinyin/qml/Keyboard_zh_url_search.qml (+1/-2) plugins/pinyin/src/pinyinplugin.h (+1/-1) plugins/pinyin/src/src.pro (+1/-1) plugins/pl/qml/Keyboard_pl.qml (+1/-2) plugins/pl/qml/Keyboard_pl_email.qml (+1/-2) plugins/pl/qml/Keyboard_pl_url.qml (+1/-2) plugins/pl/qml/Keyboard_pl_url_search.qml (+1/-2) plugins/pl/src/src.pro (+1/-1) plugins/pt/qml/Keyboard_pt.qml (+1/-2) plugins/pt/qml/Keyboard_pt_email.qml (+1/-2) plugins/pt/qml/Keyboard_pt_url.qml (+1/-2) plugins/pt/qml/Keyboard_pt_url_search.qml (+1/-2) plugins/pt/src/src.pro (+1/-1) plugins/ru/qml/Keyboard_ru.qml (+1/-2) plugins/ru/qml/Keyboard_ru_email.qml (+1/-2) plugins/ru/qml/Keyboard_ru_url.qml (+1/-2) plugins/ru/qml/Keyboard_ru_url_search.qml (+1/-2) plugins/ru/src/src.pro (+1/-1) plugins/sr/qml/Keyboard_sr.qml (+1/-2) plugins/sr/qml/Keyboard_sr_email.qml (+1/-2) plugins/sr/qml/Keyboard_sr_url.qml (+1/-2) plugins/sr/qml/Keyboard_sr_url_search.qml (+1/-2) plugins/sr/src/src.pro (+1/-1) plugins/sv/qml/Keyboard_sv.qml (+1/-2) plugins/sv/qml/Keyboard_sv_email.qml (+1/-2) plugins/sv/qml/Keyboard_sv_url.qml (+1/-2) plugins/sv/qml/Keyboard_sv_url_search.qml (+1/-2) plugins/sv/src/src.pro (+1/-1) plugins/westernsupport/spellpredictworker.cpp (+2/-3) plugins/westernsupport/spellpredictworker.h (+1/-1) plugins/westernsupport/westernlanguagesplugin.cpp (+6/-6) plugins/westernsupport/westernlanguagesplugin.h (+3/-3) qml/KeyboardContainer.qml (+13/-105) qml/keys/LanguageMenu.qml (+1/-1) qml/keys/qmldir (+20/-0) qml/qml.pro (+2/-1) src/lib/logic/abstractlanguageplugin.cpp (+2/-1) src/lib/logic/abstractlanguageplugin.h (+1/-1) src/lib/logic/languageplugininterface.h (+1/-1) src/lib/logic/wordengine.cpp (+11/-58) src/lib/logic/wordengine.h (+1/-1) src/plugin/inputmethod.cpp (+48/-1) src/plugin/inputmethod.h (+10/-0) src/plugin/inputmethod_p.h (+18/-0) src/plugin/keyboardsettings.cpp (+18/-6) src/plugin/keyboardsettings.h (+2/-0) tests/autopilot/ubuntu_keyboard/tests/test_keyboard.py (+33/-0) tests/testlayout/qml/Keyboard_testlayout.qml (+40/-0) tests/testlayout/qml/qml.pro (+20/-0) tests/testlayout/src/src.pro (+47/-0) tests/testlayout/src/testlayoutplugin.h (+25/-0) tests/testlayout/src/testlayoutplugin.json (+7/-0) tests/testlayout/testlayout.pro (+9/-0) tests/tests.pro (+1/-0) |
||||
| To merge this branch: | bzr merge lp:~michael-sheldon/ubuntu-keyboard/custom-plugin-paths | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot | continuous-integration | Needs Fixing on 2015-04-20 | |
| Ken VanDine | 2015-04-20 | Approve on 2015-04-20 | |
| Ubuntu Phablet Team | 2015-04-15 | Pending | |
|
Review via email:
|
|||
Commit Message
Allow the keyboard to load plugins from additional paths specified via gsettings.
Description of the Change
Allow the keyboard to load plugins from additional paths specified via gsettings.
| Michael Sheldon (michael-sheldon) wrote : | # |
- 350. By Michael Sheldon on 2015-04-15
-
Merge from trunk
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:349
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 351. By Michael Sheldon on 2015-04-15
-
Install missing qmldir for new keys module
- 352. By Michael Sheldon on 2015-04-15
-
Handle plugin path changes without requiring a restart of maliit-server
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:351
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:352
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 353. By Michael Sheldon on 2015-04-17
-
Add language key to testlayout for easier testing
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:353
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Michael Sheldon (michael-sheldon) wrote : | # |
Are there any related MPs required for this MP to build/function as expected? Please list.
* Yes, this system setting MR is required for plugins in custom locations to be activated: https:/
Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
* Yes
Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
* Yes
Did you successfully run all tests found in your component's Test Plan (https:/
* Yes
If you changed the UI, was the change specified/approved by design?
* No change
If you changed UI labels, did you update the pot file?
* No change
If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
* Yes
| Ken VanDine (ken-vandine) wrote : | # |
You should probably make the autopilot package depend on the same version of the ubuntu-
- 354. By Michael Sheldon on 2015-04-20
-
Update autopilot test dependencies to depend on specific version of keyboard tests package
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:354
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://

This depends on https:/ /code.launchpad .net/~michael- sheldon/ ubuntu- system- settings/ support- additional- keyboard- plugin- paths/+ merge/256286 which makes it possible to select custom plugins through system settings.
It can be tested by installing the ubuntu- keyboard- tests package and adding "/usr/share/ maliit/ tests/ubuntu- keyboard/ " to the plugin paths by running:
gsettings set com.canonical. keyboard. maliit plugin-paths "['/custom/ share/maliit/ plugins/ com/ubuntu/ lib', '/usr/share/ maliit/ tests/ubuntu- keyboard/ ']"
A layout called "Testlayout" should then be displayed in the settings panel.