Merge lp:~michael-sheldon/ubuntu-download-manager/fix-1555169 into lp:ubuntu-download-manager

Proposed by Michael Sheldon
Status: Merged
Approved by: Ken VanDine
Approved revision: 353
Merged at revision: 357
Proposed branch: lp:~michael-sheldon/ubuntu-download-manager/fix-1555169
Merge into: lp:ubuntu-download-manager
Diff against target: 13 lines (+3/-0)
1 file modified
src/downloads/priv/ubuntu/downloads/file_download.cpp (+3/-0)
To merge this branch: bzr merge lp:~michael-sheldon/ubuntu-download-manager/fix-1555169
Reviewer Review Type Date Requested Status
Ken VanDine Approve
Review via email: mp+289813@code.launchpad.net

Commit message

Fix error reporting in download manager for network errors

Description of the change

Fix error reporting in download manager for network errors

To post a comment you must log in.
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/downloads/priv/ubuntu/downloads/file_download.cpp'
2--- src/downloads/priv/ubuntu/downloads/file_download.cpp 2016-03-08 17:45:57 +0000
3+++ src/downloads/priv/ubuntu/downloads/file_download.cpp 2016-03-22 16:18:53 +0000
4@@ -537,6 +537,9 @@
5 HttpErrorStruct err(status, msg);
6 emit httpError(err);
7 errStr = NETWORK_ERROR;
8+ } else {
9+ NetworkErrorStruct err(code, _reply->errorString());
10+ emit networkError(err);
11 }
12 } else {
13 if (code == QNetworkReply::AuthenticationRequiredError) {

Subscribers

People subscribed via source and target branches