Merge lp:~michael-sheldon/gallery-app/finalize-transfers into lp:gallery-app

Proposed by Michael Sheldon
Status: Merged
Merge reported by: Arthur Mello
Merged at revision: not available
Proposed branch: lp:~michael-sheldon/gallery-app/finalize-transfers
Merge into: lp:gallery-app
Diff against target: 13 lines (+3/-0)
1 file modified
src/content-communicator.cpp (+3/-0)
To merge this branch: bzr merge lp:~michael-sheldon/gallery-app/finalize-transfers
Reviewer Review Type Date Requested Status
Ken VanDine Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+225830@code.launchpad.net

Commit message

Finalize content-hub transfers so that temporary files in ~/.cache can be cleaned up by content-hub.

Description of the change

Finalize content-hub transfers so that temporary files in ~/.cache can be cleaned up by content-hub.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Are there any related MPs required for this MP to build/function as expected? Please list.

 * Yes, requires: https://code.launchpad.net/~michael-sheldon/content-hub/fix-export-finalization/+merge/225831

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

 * Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

 * Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/gallery-app) on device or emulator?

 * Yes

If you changed the UI, was the change specified/approved by design?

 * No change

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?

 * No change

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?

 * Yes

Did CI run pass? If not, please explain why.

 * Yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?

 * Yes

review: Approve
1012. By Michael Sheldon

Merge from trunk

Revision history for this message
Arthur Mello (artmello) wrote :

Already merged on gallery-app

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/content-communicator.cpp'
2--- src/content-communicator.cpp 2014-07-03 16:09:27 +0000
3+++ src/content-communicator.cpp 2014-07-21 13:07:15 +0000
4@@ -86,6 +86,9 @@
5 }
6 QFile::copy(hubItem.url().toLocalFile(), destination);
7 }
8+ // Allow content-hub to clean up temporary files in .cache/ once we've
9+ // moved them
10+ transfer->finalize();
11 }
12
13 /*!

Subscribers

People subscribed via source and target branches