Merge lp:~michael-sheldon/content-hub/fix-notification-icon into lp:content-hub

Proposed by Michael Sheldon
Status: Merged
Approved by: Ken VanDine
Approved revision: 124
Merged at revision: 124
Proposed branch: lp:~michael-sheldon/content-hub/fix-notification-icon
Merge into: lp:content-hub
Diff against target: 13 lines (+3/-0)
1 file modified
src/com/ubuntu/content/detail/service.cpp (+3/-0)
To merge this branch: bzr merge lp:~michael-sheldon/content-hub/fix-notification-icon
Reviewer Review Type Date Requested Status
Ken VanDine Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+227898@code.launchpad.net

Commit message

Remove the Ubuntu shape from the save icon in the download snap decision.

Description of the change

Removes the Ubuntu shape from the save icon in the download snap decision.

To post a comment you must log in.
Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Are there any related MPs required for this MP to build/function as expected? Please list.

 * No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

 * Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

 * Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/content-hub) on device or emulator?

 * Yes

If you changed the UI, was the change specified/approved by design?

 * Yes

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?

 * No change

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Looks good!

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?

 * Yes

Did CI run pass? If not, please explain why.

 * Yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?

 * Yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/com/ubuntu/content/detail/service.cpp'
2--- src/com/ubuntu/content/detail/service.cpp 2014-07-07 12:39:38 +0000
3+++ src/com/ubuntu/content/detail/service.cpp 2014-07-23 11:35:43 +0000
4@@ -219,6 +219,9 @@
5 "x-canonical-snap-decisions",
6 "true");
7
8+ notify_notification_set_hint_string(notification,
9+ "x-canonical-non-shaped-icon",
10+ "true");
11
12 notify_notification_set_hint_string(notification,
13 "x-canonical-private-button-tint",

Subscribers

People subscribed via source and target branches