Merge lp:~michael-sheldon/content-hub/fix-1377334 into lp:content-hub/rtm-14.09

Proposed by Michael Sheldon on 2014-11-04
Status: Merged
Approved by: Ken VanDine on 2014-11-04
Approved revision: 156
Merged at revision: 135
Proposed branch: lp:~michael-sheldon/content-hub/fix-1377334
Merge into: lp:content-hub/rtm-14.09
Diff against target: 12 lines (+1/-1)
1 file modified
import/Ubuntu/Content/ContentTransferHint.qml (+1/-1)
To merge this branch: bzr merge lp:~michael-sheldon/content-hub/fix-1377334
Reviewer Review Type Date Requested Status
Ken VanDine 2014-11-04 Approve on 2014-11-04
Review via email: mp+240593@code.launchpad.net

Commit message

Set the caller on the ContentTransferHint dialog to allow it to be destroyed safely when its parent is destroyed.

Description of the change

Set the caller on the ContentTransferHint dialog to allow it to be destroyed safely when its parent is destroyed.

To post a comment you must log in.
Michael Sheldon (michael-sheldon) wrote :

Are there any related MPs required for this MP to build/function as expected? Please list.

 * No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

 * Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

 * Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/content-hub) on device or emulator?

 * Yes

If you changed the UI, was the change specified/approved by design?

 * No change

If you changed UI labels, did you update the pot file?

 * No change

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?

 * No change

Ken VanDine (ken-vandine) wrote :

I tested this in the MP against trunk and confirmed the diff is identical, see comment at [1]

1. https://code.launchpad.net/~michael-sheldon/content-hub/fix-1377334/+merge/238705/comments/586161

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'import/Ubuntu/Content/ContentTransferHint.qml'
2--- import/Ubuntu/Content/ContentTransferHint.qml 2014-10-10 15:28:39 +0000
3+++ import/Ubuntu/Content/ContentTransferHint.qml 2014-11-04 15:45:54 +0000
4@@ -79,7 +79,7 @@
5
6 onIsTransferRunningChanged: {
7 if (isTransferRunning) {
8- dialogue = PopupUtils.open(dialog);
9+ dialogue = PopupUtils.open(dialog, root);
10 } else {
11 PopupUtils.close(dialogue);
12 }

Subscribers

People subscribed via source and target branches