Merge lp:~michael-collison/gcc-linaro/a53-support into lp:gcc-linaro

Proposed by Michael Collison
Status: Rejected
Rejected by: Yvan Roux
Proposed branch: lp:~michael-collison/gcc-linaro/a53-support
Merge into: lp:gcc-linaro
To merge this branch: bzr merge lp:~michael-collison/gcc-linaro/a53-support
Reviewer Review Type Date Requested Status
Yvan Roux Disapprove
Review via email: mp+213537@code.launchpad.net

Description of the change

Fixed issues identified in merge review.

To post a comment you must log in.
Revision history for this message
Linaro Toolchain Builder (cbuild) wrote :

cbuild has taken a snapshot of this branch at r122168 and queued it for build.

The diff against the ancestor r122165 is available at:
 http://cbuild.validation.linaro.org/snapshots/gcc-linaro-4.8+bzr122168~michael-collison~a53-support.diff

and will be built on the following builders:
 a9-builder a9hf-builder armv5-builder i686 x86_64 xaarch64 xaarch64_bare xcortexa15hf

You can track the build queue at:
 http://cbuild.validation.linaro.org/helpers/scheduler

cbuild-snapshot: gcc-linaro-4.8+bzr122168~michael-collison~a53-support
cbuild-ancestor: lp:gcc-linaro+bzr122165
cbuild-state: check

Revision history for this message
Yvan Roux (yvan-roux) wrote :

* in gcc/ChangeLog.linaro :
  - there is a remaining tab att the end of the r202331 backport entry
* in gcc/config/aarch64/aarch64-simd.md :
  - a "a" is added on an empty line just before define_insn "aarch64_dup_lane<mode>"
  - there is 2 empty lines before ;; sha256 and ;; pmull
    (it's a small mistake from the crypto backport which we can fix here)
* in gcc/config/aarch64/t-aarch64
  - the chunk below is part of the ILP32 support and not A53
    +comma=,
    +MULTILIB_OPTIONS = $(patsubst %, mabi=%, $(subst $(comma), ,$(TM_MULTILIB_CONFIG)))
    +MULTILIB_DIRNAMES = $(subst $(comma), ,$(TM_MULTILIB_CONFIG))
* in testsuite/ChangeLog.linaro
  - the testcase was added at rev204784 and not 204782

review: Needs Fixing
Revision history for this message
Yvan Roux (yvan-roux) :
review: Disapprove

Subscribers

People subscribed via source and target branches

to all changes: