Merge lp:~micahg/firefox/firefox-3.7-20091008 into lp:~mozillateam/firefox/firefox-4.0.head.branch_format7

Proposed by Micah Gersten
Status: Merged
Merged at revision: not available
Proposed branch: lp:~micahg/firefox/firefox-3.7-20091008
Merge into: lp:~mozillateam/firefox/firefox-4.0.head.branch_format7
Diff against target: 180 lines
2 files modified
debian/changelog (+3/-2)
debian/patches/bz460917_att350845_reload_new_plugins.patch (+71/-71)
To merge this branch: bzr merge lp:~micahg/firefox/firefox-3.7-20091008
Reviewer Review Type Date Requested Status
Alexander Sack (community) Approve
Review via email: mp+13106@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Micah Gersten (micahg) wrote :

Compiled in my ppa

Revision history for this message
Alexander Sack (asac) wrote :

merged. thx

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2009-10-07 22:54:16 +0000
3+++ debian/changelog 2009-10-09 06:00:25 +0000
4@@ -1,11 +1,12 @@
5-firefox-3.7 (3.7~a1~hg20091007r33630+nobinonly-0ubuntu1) UNRELEASED; urgency=low
6+firefox-3.7 (3.7~a1~hg20091008r33669+nobinonly-0ubuntu1) UNRELEASED; urgency=low
7
8+ [ Fabien Tassin ]
9 * Mass update from 3.6 to 3.7
10 * Drop libnkgnomevfs.so from firefox-3.7-gnome-support, it's already
11 shippped in xulrunner-1.9.3-gnome-support (see bmo #512671)
12 - update debian/firefox-3.7-gnome-support.install
13
14- -- Fabien Tassin <fta@ubuntu.com> Wed, 07 Oct 2009 17:33:45 +0200
15+ -- Micah Gersten <launchpad@micahscomputing.com> Thu, 08 Oct 2009 23:33:42 -0500
16
17 firefox-3.6 (3.6~a2~hg20090810r31291+nobinonly-0ubuntu1) UNRELEASED; urgency=low
18
19
20=== modified file 'debian/patches/bz460917_att350845_reload_new_plugins.patch'
21--- debian/patches/bz460917_att350845_reload_new_plugins.patch 2009-10-07 00:49:34 +0000
22+++ debian/patches/bz460917_att350845_reload_new_plugins.patch 2009-10-09 06:00:25 +0000
23@@ -6,86 +6,86 @@
24 ===================================================================
25 --- mozilla.orig/browser/base/content/browser.js
26 +++ mozilla/browser/base/content/browser.js
27-@@ -5892,22 +5892,30 @@
28- }
29-
30- missingPluginInstaller.prototype.installSinglePlugin = function(aEvent){
31- var missingPluginsArray = {};
32-
33- var pluginInfo = getPluginInfo(aEvent.target);
34- missingPluginsArray[pluginInfo.mimetype] = pluginInfo;
35-
36-+ gBrowser.selectedBrowser.addEventListener("NewPluginInstalled",
37-+ gMissingPluginInstaller.refreshBrowser,
38-+ false);
39-+
40- if (missingPluginsArray) {
41- window.openDialog("chrome://mozapps/content/plugins/pluginInstallerWizard.xul",
42- "PFSWindow", "chrome,centerscreen,resizable=yes",
43- {plugins: missingPluginsArray, browser: gBrowser.selectedBrowser});
44- }
45-
46-+ gBrowser.selectedBrowser.removeEventListener("NewPluginInstalled",
47-+ gMissingPluginInstaller.refreshBrowser,
48-+ false);
49-+
50- aEvent.stopPropagation();
51- }
52-
53- missingPluginInstaller.prototype.managePlugins = function(aEvent){
54- BrowserOpenAddonsMgr("plugins");
55- aEvent.stopPropagation();
56- }
57-
58-@@ -5967,21 +5975,27 @@
59- var url = formatURL("plugins.update.url", true);
60- gBrowser.loadOneTab(url, {inBackground: false});
61- return true;
62- }
63-
64- function showPluginsMissing() {
65- // get the urls of missing plugins
66- var missingPluginsArray = gBrowser.selectedBrowser.missingPlugins;
67+@@ -5864,22 +5864,30 @@
68+ var gMissingPluginInstaller = {
69+
70+ installSinglePlugin: function (aEvent) {
71+ var missingPluginsArray = {};
72+
73+ var pluginInfo = getPluginInfo(aEvent.target);
74+ missingPluginsArray[pluginInfo.mimetype] = pluginInfo;
75+
76 + gBrowser.selectedBrowser.addEventListener("NewPluginInstalled",
77 + gMissingPluginInstaller.refreshBrowser,
78 + false);
79++
80 if (missingPluginsArray) {
81- window.openDialog("chrome://mozapps/content/plugins/pluginInstallerWizard.xul",
82- "PFSWindow", "chrome,centerscreen,resizable=yes",
83- {plugins: missingPluginsArray, browser: gBrowser.selectedBrowser});
84+ openDialog("chrome://mozapps/content/plugins/pluginInstallerWizard.xul",
85+ "PFSWindow", "chrome,centerscreen,resizable=yes",
86+ {plugins: missingPluginsArray, browser: gBrowser.selectedBrowser});
87 }
88+
89 + gBrowser.selectedBrowser.removeEventListener("NewPluginInstalled",
90 + gMissingPluginInstaller.refreshBrowser,
91 + false);
92- }
93-
94- if (aEvent.type == "PluginBlocklisted") {
95- if (blockedNotification || missingNotification)
96- return;
97-
98- let iconURL = "chrome://mozapps/skin/plugins/pluginBlocked-16.png";
99- let messageString = gNavigatorBundle.getString("blockedpluginsMessage.title");
100-@@ -6060,16 +6074,23 @@
101-
102- // clear the plugin list, now that at least one plugin has been installed
103- browser.missingPlugins = null;
104- if (notification) {
105- // reset UI
106- notificationBox.removeNotification(notification);
107- }
108- // reload the browser to make the new plugin show.
109-+
110-+ // reload plugins
111-+ var pm = Components.classes["@mozilla.org/plugin/manager;1"]
112-+ .getService(Components.interfaces.nsIPluginManager);
113-+ pm.reloadPlugins(false);
114-+
115-+ // ... and reload the browser to activate new plugins available
116- browser.reload();
117- }
118-
119- var gMissingPluginInstaller = new missingPluginInstaller();
120++
121+ aEvent.stopPropagation();
122+ },
123+
124+ managePlugins: function (aEvent) {
125+ BrowserOpenAddonsMgr("plugins");
126+ aEvent.stopPropagation();
127+ },
128+
129+@@ -5939,21 +5947,27 @@
130+ var url = formatURL("plugins.update.url", true);
131+ gBrowser.loadOneTab(url, {inBackground: false});
132+ return true;
133+ }
134+
135+ function showPluginsMissing() {
136+ // get the urls of missing plugins
137+ var missingPluginsArray = gBrowser.selectedBrowser.missingPlugins;
138++ gBrowser.selectedBrowser.addEventListener("NewPluginInstalled",
139++ gMissingPluginInstaller.refreshBrowser,
140++ false);
141+ if (missingPluginsArray) {
142+ openDialog("chrome://mozapps/content/plugins/pluginInstallerWizard.xul",
143+ "PFSWindow", "chrome,centerscreen,resizable=yes",
144+ {plugins: missingPluginsArray, browser: gBrowser.selectedBrowser});
145+ }
146++ gBrowser.selectedBrowser.removeEventListener("NewPluginInstalled",
147++ gMissingPluginInstaller.refreshBrowser,
148++ false);
149+ }
150+
151+ if (aEvent.type == "PluginBlocklisted") {
152+ if (blockedNotification || missingNotification)
153+ return;
154+
155+ let iconURL = "chrome://mozapps/skin/plugins/pluginBlocked-16.png";
156+ let messageString = gNavigatorBundle.getString("blockedpluginsMessage.title");
157+@@ -6032,16 +6046,23 @@
158+
159+ // clear the plugin list, now that at least one plugin has been installed
160+ browser.missingPlugins = null;
161+ if (notification) {
162+ // reset UI
163+ notificationBox.removeNotification(notification);
164+ }
165+ // reload the browser to make the new plugin show.
166++
167++ // reload plugins
168++ var pm = Components.classes["@mozilla.org/plugin/manager;1"]
169++ .getService(Components.interfaces.nsIPluginManager);
170++ pm.reloadPlugins(false);
171++
172++ // ... and reload the browser to activate new plugins available
173+ browser.reload();
174+ }
175+ };
176
177 function convertFromUnicode(charset, str)
178 {
179 try {
180+ var unicodeConverter = Components

Subscribers

People subscribed via source and target branches

to all changes: