Unity

Merge lp:~mhr3/unity/fix-1061510 into lp:unity

  1. fix-1061510
  2. Merge into trunk
Proposed by Michal Hruby
Status: Merged
Approved by: Nick Dedekind
Approved revision: no longer in the source branch.
Merged at revision: 2821
Proposed branch: lp:~mhr3/unity/fix-1061510
Merge into: lp:unity
Diff against target: 12 lines (+1/-1)
1 file modified
launcher/TrashLauncherIcon.cpp (+1/-1)
To merge this branch: bzr merge lp:~mhr3/unity/fix-1061510
Reviewer Review Type Date Requested Status
Nick Dedekind (community) Approve
jenkins continuous-integration Pending
Review via email: mp+128915@code.launchpad.net

Commit message

Fix ref-counting issue in TrashLauncherIcon

Description of the change

Fix ref-counting issue in TrashLauncherIcon.

To post a comment you must log in.
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'launcher/TrashLauncherIcon.cpp'
2--- launcher/TrashLauncherIcon.cpp 2012-09-18 01:13:12 +0000
3+++ launcher/TrashLauncherIcon.cpp 2012-10-10 11:55:59 +0000
4@@ -127,7 +127,7 @@
5
6 if (info)
7 {
8- glib::Object<GIcon> icon(g_file_info_get_icon(info));
9+ glib::Object<GIcon> icon(g_file_info_get_icon(info), glib::AddRef());
10 glib::String icon_string(g_icon_to_string(icon));
11
12 self->icon_name = icon_string.Str();