Merge lp:~mhr3/unity-lens-files/fix-actions-order into lp:unity-lens-files

Proposed by Michal Hruby
Status: Merged
Approved by: Łukasz Zemczak
Approved revision: 233
Merged at revision: 233
Proposed branch: lp:~mhr3/unity-lens-files/fix-actions-order
Merge into: lp:unity-lens-files
Diff against target: 41 lines (+9/-8)
1 file modified
src/daemon.vala (+9/-8)
To merge this branch: bzr merge lp:~mhr3/unity-lens-files/fix-actions-order
Reviewer Review Type Date Requested Status
Łukasz Zemczak Approve
Review via email: mp+120365@code.launchpad.net

Commit message

Fix the order of the actions to match the design

Description of the change

Fix the order of the actions to match the design.

To post a comment you must log in.
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Looks cool! Let's see if the merger pushes it to the staging PPA now.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/daemon.vala'
2--- src/daemon.vala 2012-08-13 15:29:32 +0000
3+++ src/daemon.vala 2012-08-20 11:11:20 +0000
4@@ -953,7 +953,11 @@
5
6 string mime_type = finfo.get_content_type ();
7 preview.add_info (new InfoHint ("format", _("Format"), null, GLib.ContentType.get_description (mime_type)));
8-
9+
10+ var open_action = new Unity.PreviewAction ("open", _("Open"), null);
11+ open_action.activated.connect (on_preview_open);
12+ preview.add_action (open_action);
13+
14 int64 total_size = 0;
15 if (finfo.get_file_type () == GLib.FileType.DIRECTORY)
16 {
17@@ -980,20 +984,17 @@
18 total_size = finfo.get_size ();
19 preview.add_info (new InfoHint ("size", _("Size"), null, GLib.format_size (total_size)));
20
21+ var open_folder_action = new Unity.PreviewAction ("open-dir", _("Show in Folder"), null);
22+ open_folder_action.activated.connect (on_preview_open_folder);
23+ preview.add_action (open_folder_action);
24+
25 if (email_app_info != null)
26 {
27 var email_action = new Unity.PreviewAction ("email", _("Email"), null);
28 email_action.activated.connect (on_email_file);
29 preview.add_action (email_action);
30 }
31- var open_folder_action = new Unity.PreviewAction ("open-dir", _("Show in Folder"), null);
32- open_folder_action.activated.connect (on_preview_open_folder);
33- preview.add_action (open_folder_action);
34 }
35-
36- var open_action = new Unity.PreviewAction ("open", _("Open"), null);
37- open_action.activated.connect (on_preview_open);
38- preview.add_action (open_action);
39 }
40 else
41 {

Subscribers

People subscribed via source and target branches