Merge lp:~mhr3/unity-lens-files/bump-valac-req into lp:unity-lens-files

Proposed by Michal Hruby
Status: Merged
Approved by: Łukasz Zemczak
Approved revision: 230
Merged at revision: 230
Proposed branch: lp:~mhr3/unity-lens-files/bump-valac-req
Merge into: lp:unity-lens-files
Diff against target: 40 lines (+4/-4)
3 files modified
configure.ac (+1/-1)
src/folder.vala (+1/-1)
src/utils.vala (+2/-2)
To merge this branch: bzr merge lp:~mhr3/unity-lens-files/bump-valac-req
Reviewer Review Type Date Requested Status
Łukasz Zemczak Approve
Paweł Stołowski (community) Approve
Review via email: mp+115902@code.launchpad.net

Commit message

Fix compilation issues with latest valac

Description of the change

Fix compilation issues with latest valac and bump the version requirement.

To post a comment you must log in.
Revision history for this message
Unity Merger (unity-merger) wrote :

No commit message specified.

Revision history for this message
Paweł Stołowski (stolowski) wrote :

Compiles now with vala 0.16 and works fine.

review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity-lens-files/26/console reported an error when processing this lp:~mhr3/unity-lens-files/bump-valac-req branch.
Not merging it.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Distro changes pushed - we're all green here!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'configure.ac'
2--- configure.ac 2012-04-12 07:53:05 +0000
3+++ configure.ac 2012-07-20 07:47:22 +0000
4@@ -16,7 +16,7 @@
5 # Init the other things we depend on
6 #####################################################
7 AM_MAINTAINER_MODE
8-AM_PROG_VALAC([0.14.0])
9+AM_PROG_VALAC([0.16.0])
10 AS_IF([test -z "$VALAC"], [AC_MSG_ERROR(["No valac compiler found."])])
11 AC_PROG_CC
12 AM_PROG_CC_C_O
13
14=== modified file 'src/folder.vala'
15--- src/folder.vala 2012-04-05 14:53:12 +0000
16+++ src/folder.vala 2012-07-20 07:47:22 +0000
17@@ -208,7 +208,7 @@
18
19 }
20
21- private class Bookmark : Object
22+ public class Bookmark : Object
23 {
24 public string uri { get; set construct; }
25 public string icon { get; set construct; }
26
27=== modified file 'src/utils.vala'
28--- src/utils.vala 2012-03-02 16:04:21 +0000
29+++ src/utils.vala 2012-07-20 07:47:22 +0000
30@@ -99,8 +99,8 @@
31 public int cmp_file_info_by_mtime (FileInfo info1, FileInfo info2)
32 {
33 TimeVal tv1, tv2;
34- info1.get_modification_time (out tv1);
35- info2.get_modification_time (out tv2);
36+ tv1 = info1.get_modification_time ();
37+ tv2 = info2.get_modification_time ();
38 long cmp = tv1.tv_sec - tv2.tv_sec;
39 return cmp < 0 ? 1 : ( cmp > 0 ? -1 : 0);
40 }

Subscribers

People subscribed via source and target branches