Merge lp:~mhr3/unity-lens-applications/fix-986191 into lp:unity-lens-applications

Proposed by Michal Hruby
Status: Merged
Approved by: Gord Allott
Approved revision: 284
Merged at revision: 284
Proposed branch: lp:~mhr3/unity-lens-applications/fix-986191
Merge into: lp:unity-lens-applications
Diff against target: 21 lines (+3/-1)
1 file modified
src/daemon.vala (+3/-1)
To merge this branch: bzr merge lp:~mhr3/unity-lens-applications/fix-986191
Reviewer Review Type Date Requested Status
Gord Allott (community) Approve
Review via email: mp+103102@code.launchpad.net

Commit message

Don't linger if Zeitgeist fails to start

Description of the change

A bug in libzeitgeist causes that if zeitgeist fails to start, async methods linger indefinitely, which means the lens is just waiting for zeitgeist to returns either results or an error, but none of these happens, and the lens appears non functional.

Reset the flag which causes us to wait for zeitgeist results immediately, so only the first search will fail - successive searches will then work properly.

To post a comment you must log in.
Revision history for this message
Gord Allott (gordallott) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/daemon.vala'
2--- src/daemon.vala 2012-04-18 22:50:48 +0000
3+++ src/daemon.vala 2012-04-23 14:04:22 +0000
4@@ -211,6 +211,9 @@
5 {
6 if (popularities_dirty)
7 {
8+ popularities_dirty = false;
9+ // we're not passing the cancellable, cause cancelling this search
10+ // shouldn't cancel getting most popular apps
11 yield update_popularities ();
12 if (cancellable.is_cancelled ()) return;
13 }
14@@ -435,7 +438,6 @@
15 {
16 warning ("%s", err.message);
17 }
18- popularities_dirty = false;
19 }
20
21 private async void update_scope_search (Unity.LensSearch search,

Subscribers

People subscribed via source and target branches