Code review comment for lp:~mhr3/libzeitgeist/fix-986230

Revision history for this message
Siegfried Gevatter (rainct) wrote :

2012/4/27 Mikkel Kamstrup Erlandsen <email address hidden>:
> 60      + else if (priv->log_error)
> 61      + {
>
> Should there not be a g_clear_error() in this branch?

No, the error is still needed.

> 195     + goto process_pending_calls;
>
> Why this? We supposedly don't have a proxy to process the pending calls on?

The code in dispatch_method will run the callback itself giving it the
error code we received when connecting.

« Back to merge proposal