Merge lp:~mhr3/libunity/new-tag-api into lp:libunity

Proposed by Michal Hruby
Status: Merged
Approved by: Mirco Müller
Approved revision: 101
Merged at revision: 101
Proposed branch: lp:~mhr3/libunity/new-tag-api
Merge into: lp:libunity
Diff against target: 60 lines (+10/-8)
1 file modified
src/unity-lens-tools.vala (+10/-8)
To merge this branch: bzr merge lp:~mhr3/libunity/new-tag-api
Reviewer Review Type Date Requested Status
Unity Team Pending
Review via email: mp+87445@code.launchpad.net

Description of the change

Use new Dee.ModelTag API as proposed in lp:~mhr3/dee/vala-tags

To post a comment you must log in.
Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-libunity/21/console reported an error when processing this lp:~mhr3/libunity/new-tag-api branch.
Not merging it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/unity-lens-tools.vala'
2--- src/unity-lens-tools.vala 2011-08-05 16:19:21 +0000
3+++ src/unity-lens-tools.vala 2012-01-04 09:27:33 +0000
4@@ -129,7 +129,7 @@
5 public unowned Dee.Model receiver { get; construct; }
6 private Gee.ArrayList<unowned Dee.Model> _providers;
7
8- private Gee.HashMap<unowned Dee.Model, unowned Dee.ModelTag> _provider_tags;
9+ private Gee.HashMap<unowned Dee.Model, Dee.ModelTag<unowned Dee.ModelIter>> _provider_tags;
10
11 public ResultsSynchronizer (Dee.Model receiver)
12 {
13@@ -139,7 +139,7 @@
14 construct
15 {
16 _providers = new Gee.ArrayList<unowned Dee.Model> ();
17- _provider_tags = new Gee.HashMap<unowned Dee.Model, unowned Dee.ModelTag> ();
18+ _provider_tags = new Gee.HashMap<unowned Dee.Model, Dee.ModelTag<unowned Dee.ModelIter>> ();
19 }
20
21 public void add_provider (Dee.Model provider, string uid)
22@@ -147,7 +147,7 @@
23 provider.set_data<string>("uid", "%s:".printf(uid));
24
25 _providers.add (provider);
26- _provider_tags.set (provider, provider.register_tag ((d) => {}));
27+ _provider_tags[provider] = new Dee.ModelTag<unowned Dee.ModelIter> (provider);
28
29 provider.row_added.connect (on_row_added);
30 provider.row_removed.connect (on_row_removed);
31@@ -165,13 +165,15 @@
32 provider.get_string (iter, 4),
33 provider.get_string (iter, 5),
34 provider.get_string (iter, 6));
35- provider.set_tag (iter, _provider_tags.get (provider), i);
36+
37+ var tag = _provider_tags[provider];
38+ tag [provider, iter] = i;
39 }
40
41 private void on_row_removed (Dee.Model provider, Dee.ModelIter iter)
42 {
43- unowned Dee.ModelTag tag = _provider_tags.get (provider);
44- unowned Dee.ModelIter riter = (Dee.ModelIter)provider.get_tag (iter, tag);
45+ var tag = _provider_tags[provider];
46+ unowned Dee.ModelIter riter = tag[provider, iter];
47
48 if (riter != null)
49 {
50@@ -185,8 +187,8 @@
51
52 private void on_row_changed (Dee.Model provider, Dee.ModelIter iter)
53 {
54- unowned Dee.ModelTag tag = _provider_tags.get (provider);
55- unowned Dee.ModelIter riter = (Dee.ModelIter)provider.get_tag (iter, tag);
56+ var tag = _provider_tags[provider];
57+ unowned Dee.ModelIter riter = tag[provider, iter];
58
59 if (riter != null)
60 {

Subscribers

People subscribed via source and target branches