libunity

Merge lp:~mhr3/libunity/movie-preview-hide-rating into lp:libunity

  1. movie-preview-hide-rating
  2. Merge into trunk
Proposed by Michal Hruby
Status: Merged
Approved by: Paweł Stołowski
Approved revision: 174
Merged at revision: 174
Proposed branch: lp:~mhr3/libunity/movie-preview-hide-rating
Merge into: lp:libunity
Diff against target: 21 lines (+2/-2)
1 file modified
protocol/protocol-previews.vala (+2/-2)
To merge this branch: bzr merge lp:~mhr3/libunity/movie-preview-hide-rating
Reviewer Review Type Date Requested Status
Paweł Stołowski (community) Approve
Review via email: mp+124224@code.launchpad.net

Commit message

Allow passing -1 as rating value

Description of the change

Allow passing -1 as rating which signifies to the preview widget to hide itself.

To post a comment you must log in.
Revision history for this message
Paweł Stołowski (stolowski) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'protocol/protocol-previews.vala'
2--- protocol/protocol-previews.vala 2012-08-20 14:57:40 +0000
3+++ protocol/protocol-previews.vala 2012-09-13 15:19:37 +0000
4@@ -416,7 +416,7 @@
5 if (last_update != null)
6 properties["last-update"] = last_update;
7
8- if (rating >= 0.0f)
9+ if (rating >= -1.0f)
10 properties["rating"] = (double) rating;
11 if (num_ratings > 0)
12 properties["num-ratings"] = num_ratings;
13@@ -547,7 +547,7 @@
14 {
15 base.add_properties (properties);
16
17- if (rating >= 0.0f)
18+ if (rating >= -1.0f)
19 properties["rating"] = (double) rating;
20 if (num_ratings > 0)
21 properties["num-ratings"] = num_ratings;

Subscribers

People subscribed via source and target branches