Merge lp:~mhr3/libunity/fix-sources-update into lp:libunity
Proposed by
Michal Hruby
Status: | Merged |
---|---|
Approved by: | Mikkel Kamstrup Erlandsen |
Approved revision: | 128 |
Merged at revision: | 128 |
Proposed branch: | lp:~mhr3/libunity/fix-sources-update |
Merge into: | lp:libunity |
Diff against target: |
27 lines (+6/-1) 1 file modified
src/unity-lens-private.vala (+6/-1) |
To merge this branch: | bzr merge lp:~mhr3/libunity/fix-sources-update |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mikkel Kamstrup Erlandsen (community) | Approve | ||
Review via email: mp+98436@code.launchpad.net |
Commit message
Make sure all scopes are updated when the filtering state of sources filter changes
Description of the change
Make sure all scopes are updated when the filtering state of sources filter changes
To post a comment you must log in.
Looking correct.
I was pondering for quite a while if we needed tests for this. I came to the conclusion that we didn't because upon inspecting the code the only line that changes the logic is an extra or-clause, which can only lead us to updating the scopes more often. Not to, fx, not updating them.