Merge lp:~mhr3/libunity/fix-940161 into lp:libunity

Proposed by Michal Hruby on 2012-04-20
Status: Merged
Approved by: Mikkel Kamstrup Erlandsen on 2012-04-20
Approved revision: 136
Merged at revision: 136
Proposed branch: lp:~mhr3/libunity/fix-940161
Merge into: lp:libunity
Diff against target: 15 lines (+3/-1)
1 file modified
src/unity-lens-private.vala (+3/-1)
To merge this branch: bzr merge lp:~mhr3/libunity/fix-940161
Reviewer Review Type Date Requested Status
Mikkel Kamstrup Erlandsen (community) 2012-04-20 Approve on 2012-04-20
Review via email: mp+102818@code.launchpad.net

Commit message

Don't show the sources filter if there's just one item

Description of the change

Only show the sources filter only if there are at least two items.

Trivial change, no new tests.

To post a comment you must log in.

Clever. Tests not required, trivial change.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/unity-lens-private.vala'
2--- src/unity-lens-private.vala 2012-04-18 10:29:26 +0000
3+++ src/unity-lens-private.vala 2012-04-20 08:56:21 +0000
4@@ -383,8 +383,10 @@
5 }
6 }
7
8- if (_sources.options.length () > 0)
9+ if (_sources.options.length () > 1)
10 {
11+ // We could add the sources filter if there are > 0 options, and
12+ // use the visibility hint but unity currently ignores it
13 var filter = _sources;
14
15 string icon_hint_s = filter.icon_hint != null ?

Subscribers

People subscribed via source and target branches