Merge lp:~mhr3/libunity/fix-1214125 into lp:libunity

Proposed by Michal Hruby
Status: Merged
Approved by: Paweł Stołowski
Approved revision: 280
Merged at revision: 280
Proposed branch: lp:~mhr3/libunity/fix-1214125
Merge into: lp:libunity
Diff against target: 31 lines (+10/-7)
1 file modified
bindings/python/Unity.py (+10/-7)
To merge this branch: bzr merge lp:~mhr3/libunity/fix-1214125
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Paweł Stołowski (community) Approve
Review via email: mp+181005@code.launchpad.net

Commit message

Use proper overrides for ScopeResult.

Description of the change

Use proper overrides for ScopeResult.

To post a comment you must log in.
Revision history for this message
Paweł Stołowski (stolowski) wrote :

Looks good. +1

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bindings/python/Unity.py'
2--- bindings/python/Unity.py 2013-08-14 14:51:08 +0000
3+++ bindings/python/Unity.py 2013-08-20 10:24:26 +0000
4@@ -94,11 +94,14 @@
5 return result
6
7
8-def scope_result_create(*args, **kwargs):
9- if len(kwargs) > 0:
10- result = kwargs_to_result_variant(**kwargs)
11- return Unity.ScopeResult.create_from_variant(result)
12- return original_scope_result_create(*args)
13+class ScopeResult(Unity.ScopeResult):
14+
15+ @staticmethod
16+ def create(*args, **kwargs):
17+ if len(kwargs) > 0:
18+ result = kwargs_to_result_variant(**kwargs)
19+ return Unity.ScopeResult.create_from_variant(result)
20+ return Unity.ScopeResult.create(*args)
21
22
23 ScopeSearchBase = override(ScopeSearchBase)
24@@ -107,5 +110,5 @@
25 __all__.append('ResultPreviewer')
26 ResultSet = override(ResultSet)
27 __all__.append('ResultSet')
28-original_scope_result_create = Unity.ScopeResult.create
29-Unity.ScopeResult.create = scope_result_create
30+ScopeResult = override(ScopeResult)
31+__all__.append('ScopeResult')

Subscribers

People subscribed via source and target branches