Merge lp:~mhr3/gsettings-qt/fix-wrong-unref into lp:gsettings-qt

Proposed by Michal Hruby
Status: Merged
Approved by: Lars Karlitski
Approved revision: 49
Merged at revision: 49
Proposed branch: lp:~mhr3/gsettings-qt/fix-wrong-unref
Merge into: lp:gsettings-qt
Diff against target: 12 lines (+1/-1)
1 file modified
src/qgsettings.cpp (+1/-1)
To merge this branch: bzr merge lp:~mhr3/gsettings-qt/fix-wrong-unref
Reviewer Review Type Date Requested Status
Lars Karlitski (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+217891@code.launchpad.net

Commit message

Fix incorrect unref call.

Description of the change

Fix incorrect unref call, which causes a critical on each invocation of the method.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Lars Karlitski (larsu) wrote :

Ah, thanks for the catch.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qgsettings.cpp'
2--- src/qgsettings.cpp 2014-04-08 09:28:52 +0000
3+++ src/qgsettings.cpp 2014-05-01 08:46:50 +0000
4@@ -147,7 +147,7 @@
5 GSettingsSchemaSource *source = g_settings_schema_source_get_default ();
6 GSettingsSchema *schema = g_settings_schema_source_lookup (source, schema_id.constData(), TRUE);
7 if (schema) {
8- g_object_unref (schema);
9+ g_settings_schema_unref (schema);
10 return true;
11 } else {
12 return false;

Subscribers

People subscribed via source and target branches

to all changes: