Merge lp:~mhr3/geis/fix-autogen into lp:geis

[Michal Hruby]

Invoke configure as last step of autogen

Invoke configure in autogen, this fixes build when using jhbuild.

[Chase Douglas (chasedouglas)]

I'm ok with this change.

Can you propagate this change to other projects: evemu, frame, grail?

review: Approve

[Daniel d'Andrada (dandrader)]

I don't think this is a good idea. I think autogen should just generate configure and not run it as well.

a lot of times, for projects I'm new to, I just want to see what are the parameters etc and therefore do a "configure --help". I cannot do it if autogen already calls configure. "autogen --help" will give me the help of autogen and not the one from configure.

http://sources.redhat.com/autobook/autobook/autobook_43.html#IDX1

And a related discussion:
http://bugs.mysql.com/bug.php?id=49256

review: Disapprove

[Michal Hruby (mhr3)]

Sorry Daniel, in the GNOME platform autogen usually runs configure as well, and the tools we use expect that. FWIW you can use the NOCONFIGURE envvar to not run it.

=== modified file 'autogen.sh'
--- autogen.sh	2010-07-23 13:58:53 +0000
+++ autogen.sh	2012-08-06 10:21:05 +0000
@@ -1,2 +1,12 @@
 #!/bin/sh
-autoreconf -ifv
+
+srcdir=`dirname $0`
+test -z "$srcdir" && srcdir=.
+
+ORIGDIR=`pwd`
+cd $srcdir
+
+autoreconf --force --verbose --install || exit 1
+cd $ORIGDIR || exit $?
+test -n "$NOCONFIGURE" || "$srcdir/configure" "$@"
+